I am not sure if i did the prefered/correct way for keeping a square inside a rectangle. Can anyone please check?
And also in general tell me if there are any major beginner mistakes that i have done, which could have been avoided or done in a better way.
@Lemon-stack
Posted
You did good👍 Here's what I think : • You didn't had to necessarily upload all the work files, they were for guidance. Only your HTML, CSS and image files would do. • Giving a class and setting it's background-image wasn't really necessary, you could have just included your image tag and adjust the width and height settings. Apart from that.... your solution was 🎯 I hope you found this helpful 😊.... Happy Coding 🌟
Marked as helpful
@Andigashi1
Posted
Hey i'll do my best to help with the experience i have. Firstly i suggest that you separate the css from the html by writing it in a separate file. Second, instead of creating the .square div, it would be easier to put the img directly in the html not in the css and giv it the margin there. And lastly in order to use the correct colors, the zip files provides you with a styles-guide.md which contains all the colors, font sizes and families.
Marked as helpful
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
