Skip to content
OverviewSolutions
10
Comments
2
Lance Liang
@LanceLiang2011

All comments

  • Lance Liang•210
    @LanceLiang2011Posted over 1 year ago

    Hi Adriam,

    Firstly, I want to commend you on the remarkable job you've done on this project. Your hard work and attention to detail are evident.

    However, there are a few minor issues regarding the logic of date calculation that need addressing. For instance, when inputting the date from yesterday into your calculator, it returns '-1 month and 1 day'. This can be attributed to JavaScript's usage of zero-based indexing for month. It would be beneficial to take this peculiarity into account to refine your calculations and provide more precise results.

    Additionally, the current front-end data checking allows input of dates from the next month. This might unintentionally disrupt your user interface.

    Accurate date calculation in JavaScript, especially accounting for leap years, can be quite challenging. If you find this to be the case, consider integrating a third-party library, such as Moment.js or date-fns, which can greatly simplify the process and ensure precision.

    Keep up the good work!

    Marked as helpful
    0
  • Lance Liang•210
    @LanceLiang2011Posted over 1 year ago

    Hello Geordy,

    I must say that I'm truly impressed with the amount of work and detail you've put into this project - your solution is excellent! I do, however, have a couple of UX-related observations and a question for you.

    Feedback:

    I noticed that when hovering over the steps in your sidebar, my cursor changes to a pointer. However, these numbers are not clickable, which could potentially confuse users.

    I experienced some screen flashing when I selected all add-ons on page 3 and then navigated to page 4. I'm unsure of what's causing this, but I believe it's something that needs to be addressed.

    Question: Your project is a single page application, and you've chosen to use Astro.build as your framework. Can you share your specific reasons for this choice?

    Overall, this is one of the best solution for this project I've seen on FM so far, Keep up the good work!

    Marked as helpful
    2