Skip to content
OverviewSolutions
5
Comments
3
Kenneth
@Kenmw

All comments

  • Kenneth•95
    @KenmwPosted about 3 years ago

    hey Avdhoot,this looks to be a great solution.i also just completed this challenge and am inspired on how you you grid to center the items,will definately be trying this out. However you seem to have overlooked the following:

    1.instead of having the footer where you placed it you could use a div,or a section so as to reserve the footer element to an actual page footer.

    2.The 2 divs in your footer could more accurately be described with anchor tags since they are links to certain other pages.but to apply css you may still create a class for the anchor tags.so for example the button class might look like this

    <a class="button" href="#">Procced to Payment</a>

    3.from the design images,there is a different background color(and some properties)for the 3 links when you hover over them.i see you did this with your .link class,you may want to incoporate this idea in the other 2 links as well

    otherwise great solution and happy coding!!

    Marked as helpful
    0
  • Kenneth•95
    @KenmwPosted almost 4 years ago

    hey Prudhvi,no you did not overdo things. Apart from the colors this solution looks perfect. for the pattern gradients you will notice there is an image named bg-pattern.svg in the images folder that comes with this project that could be useful in your div with class name head and 2 other svgs bg-pattern-bottom and bg-pattern top* that you could use as backgroundimages in the body.Also try to take your colors from the style-guide.md if you want to have colors similar to the design, otherwise happy coding!!

    0
  • Jeuri Morel•1,405
    @JeuriMorelSubmitted almost 4 years ago

    I struggled with media query styles not overriding original styling (mostly dealing with margins) and in the end had to use '!important' to get them to stick. Am not happy with that solution as from what I heard it's not considered best practice. I imported the media queries after the original styles, and assumed that that would work, but it didn't. Is there some resource that explains in detail how this works?

    Testimonials slider

    2
    Kenneth•95
    @KenmwPosted almost 4 years ago

    hey Jeuri, great work you did here.since your css is minified its kinda hard to go through it.i noticed that the attribution doesn't stick to the bottom in mobile view through.to make it stick I would suggest you include this code snippet in the .attribution div

    position:absolute ;
bottom:0;
margin:0 auto;  //to center the content

    since am also a newbie my margin:auto; sometimes doesn't work in which case I try out this code instead of margin 

    display :flex;
justify-content:center ;

    I hope this helps.cheers

    1