Design comparison
Community feedback
- @EbunskiPosted about 3 years ago
Great work. Loved the way you used css variables. Seems you left out the hover states. Also I feel you should have adjusted the width for the mobile.
Marked as helpful0@avdhootttPosted about 3 years ago@Ebunski Thanks for the Feedback, I'll make the changes.
0 - @KenmwPosted about 3 years ago
hey Avdhoot,this looks to be a great solution.i also just completed this challenge and am inspired on how you you grid to center the items,will definately be trying this out. However you seem to have overlooked the following:
1.instead of having the footer where you placed it you could use a div,or a section so as to reserve the footer element to an actual page footer.
2.The 2 divs in your footer could more accurately be described with anchor tags since they are links to certain other pages.but to apply css you may still create a class for the anchor tags.so for example the
button
class might look like this<a class="button" href="#">Procced to Payment</a>
3.from the design images,there is a different background color(and some properties)for the 3 links when you hover over them.i see you did this with your
.link
class,you may want to incoporate this idea in the other 2 links as wellotherwise great solution and happy coding!!
Marked as helpful0@avdhootttPosted about 3 years ago@Kenmw Thanks for the reply buddy, the suggestion of anchor tags is actually great. I will make the changes in the code. Thanks Again..
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord