mokua• 10
@JamesMokua
Submitted
Kenbak
@Kenbak
All comments
- Kenbak• 40
@Kenbak
Posted
Hello friend! Congrats on your first challenge!
You might want to change the background color to:
body { background-color:hsl(212, 45%, 89%) }And the paragraph color to a lightgray!
You can also use this code to center your elements:
body { min-height: 100vh; display: grid; place-content: center; }Hope it helped, and will be looking forward to your next challenges!
0 - Eliabe• 200
@eliabedasilva
Submitted
This was my first project on the platform and it wasn't much of a challenge I just had to study a little about flexbox and the implementation with github pages. Overall it was a very fun and very productive process.
Kenbak• 40@Kenbak
Posted
Congrats on your first challenge ser. It's very impressive. The card is the exact same size.
Instead on using margin top and bottom on the texts elements, I would put them all in a div, using flex and flex-column. Then add a justify-content-around and it should do the trick and be more symmetrical!
Also you can reduce a bit the line height on the H1 to make it perfect ;)
Marked as helpful
1 - Saadi Sidali• 100
@SaadiSidali
Submitted
Kenbak• 40@Kenbak
Posted
Hello Saadi,
You can also use this code to center the elements:
body { min-height: 100vh; display: grid; place-content: center; }The card also looks a bit small, you might want to make it bigger! It's a great idea to have added a bit of shadow, but you might want to make it a tiny bit less visible. Congrats on your first challenge!
0 - Monerhex39bg• 10
@Monerhex39bg
Submitted
Kenbak• 40@Kenbak
Posted
Congrats on your first challenge friend!
I would put this code in the body selector so the component is centered.
min-height: 100vh; display: grid; place-content: center; }Also you might want to use a separate css stylesheet so your code is more readable. It doesn't matter for small projects like this one, but it will become hard to follow through on more developed apps.
0
