Design comparison
Solution retrospective
This was my first project on the platform and it wasn't much of a challenge I just had to study a little about flexbox and the implementation with github pages. Overall it was a very fun and very productive process.
Community feedback
- @elaineleungPosted over 2 years ago
Hi Eliabe, welcome to Frontend Mentor, and great job working on this challenge, as it looks really good! 😊
One suggestion I have is to use
height: 100%
for#image
instead of the fixed pixel height you have; the reason is, in mobile view when I resize the browser and make the width smaller than 300px (I wasn't intentionally trying to do this, more of an accident but led me to discover this), the image separates from the text, and usingheight: 100%
can keep that from happening here. You can also add adisplay: block
to yourimg
to remove that tiny almost 1px spacing that's underneath the image, which occurs due toimg
being an inline element and thus have properties like line height. Well done on the whole!Marked as helpful1@eliabedasilvaPosted about 2 years ago@elaineleung I also encountered this problem of the image separating from the text, but I had no idea how to solve it. Thanks for the guidance.
0 - @KenbakPosted over 2 years ago
Congrats on your first challenge ser. It's very impressive. The card is the exact same size.
Instead on using margin top and bottom on the texts elements, I would put them all in a div, using flex and flex-column. Then add a justify-content-around and it should do the trick and be more symmetrical!
Also you can reduce a bit the line height on the H1 to make it perfect ;)
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord