Skip to content
OverviewSolutions
18
Comments
2
CodingDuck
@KaskaS-O

All comments

  • CodingDuck•390
    @KaskaS-OPosted about 3 years ago

    Hi!

    Congrats on finishing the challenge :) I have some remarks, hope they'll be helpful.

    1. I see you used 'index.css' name for a stylesheet. It's better not to (index is a default name for a main html file). It can cause some problems when you're referring to a file from some script.

    2. You used h2 and h4 markups for titles. The best is to start with h1 for page's main title and to go with consecutive numbers for subtitles, sections's titles e.t.c. It's important especially for accessibility. I know sometimes it's not comfortable and I myself make exceptions from that rule, but when it's possible it's worth of doing.

    3. For practicing using Git and showing you're comfortable with it (to your future employer looking at your Github) try to use more commits. I know some projects aren't too complex and you can even finish them in short time no walking from the computer, but use the opportunity to familiarize with version control.

    4. When you check your layout with desing using Frontend Challenge design comparison you can see your components are a bit smaller and positioned closer to the top of the page. Your layout looks ok, these are details, but it always can be better, can't it? ;)

    Good luck with next challenges! You'll see it's more fun with every challenge you take :)

    Marked as helpful
    1
  • CodingDuck•390
    @KaskaS-OPosted about 3 years ago

    Hey @kelvintheophil!

    Good job with the challenge :)

    I am also quite new to Frontend Mentor and it's actually my first feedback ever, hope it'll be helpful.

    A couple of remarks after quick checking your code:

    • The main component is missing shadow which you can see in the design,
    • I would advice on moving footer styles (the ones added to index.html automatically) to your stylesheet from main html file, just to keep code clean and all the css in other place,
    • When using media queries I think it's better to place them right below the part of the code they're changing (in your case it mean creating media query for each element separatery e.g. .container-grid, .section-two-flex etc.). It requires more code, but when your project grows it's easier to find the element you want to take care of at the moment.

    Good luck with futher coding! Kaska

    Marked as helpful
    1