single price grid comp

Community feedback

• 

  CodingDuck•390

  @KaskaS-OPosted about 3 years ago

  Hey @kelvintheophil!

  Good job with the challenge :)

  I am also quite new to Frontend Mentor and it's actually my first feedback ever, hope it'll be helpful.

  A couple of remarks after quick checking your code:

  • The main component is missing shadow which you can see in the design,
  • I would advice on moving footer styles (the ones added to index.html automatically) to your stylesheet from main html file, just to keep code clean and all the css in other place,
  • When using media queries I think it's better to place them right below the part of the code they're changing (in your case it mean creating media query for each element separatery e.g. .container-grid, .section-two-flex etc.). It requires more code, but when your project grows it's easier to find the element you want to take care of at the moment.

  Good luck with futher coding! Kaska

  Marked as helpful

  1

  ---

  

  kelvintheophil•80

  @kelvintheophilPosted about 3 years ago

  @KaskaS-O thanks a lot mate for your feedback hope we gonna get along really well looking forward to it

  0
• 

  P

  Dave•5,295

  @dwhensonPosted about 3 years ago

  Hi @kelvintheophil lovely job here! 🙌

  One small feedback is to try and keep your headings in a logical order.

  What this means is that you should use the <h1> headings as main headings of your web page, followed by the <h2> headings, then the less important <h3> headings, and so on, without skipping a level.

  This is really important as many people using assistive tech to access your pages will navigate the site based on the heading structure. At the moment this wouldn’t work with your HTML.

  I approach this by first laying out the page using only HTML and only thinking about the document structure, not design at all, and then once done returning to the page and using CSS to make things look how they should.

  We shouldn’t use headings to make text look BIG or bold. Use them only for setting out the heading of your document and to show the document structure, and then change things up with CSS after that.

  Hope this helps!

  Cheers 👋

  Dave

  Marked as helpful

  1

  ---

  

  kelvintheophil•80

  @kelvintheophilPosted about 3 years ago

  @dwhenson thanks Dave ... working on it as of now hope you will see my next project challenge

  0