All comments

• 

  Oscar Daniel Piñeros Hernández•60

  @odpineroshSubmitted over 3 years ago

  Hi! I would like some feedback on my code. What could be better done?

  Thank you!

  

  Single price component. Used Bootstrap!

  2

  10
  

  Nabil Tharwat•0

  @KL13NTPosted over 3 years ago

  Hi Oscar, I notice you use the HTML attribute "class" on all elements even when you don't assign any classes, why is that? Your HTML would be completely valid without them as well, and perhaps a little more readable.

  What you could do to get a closer result to the design is to set the container width to less than 100%. Maybe 40? And apply a bit of box-shadow to match the design.

  To avoid the Flash of Invisible Text (which results from loading the font and using it directly) you could use the font-display css property to change how the browser displays the font. Read more here: https://css-tricks.com/font-display-masses/

  0

  This comment has received 1 replyShow