Single price component. Used Bootstrap!
Design comparison
Solution retrospective
Hi! I would like some feedback on my code. What could be better done?
Thank you!
Community feedback
- @aboalfadel1Posted over 3 years ago
good job
0 - @KL13NTPosted over 3 years ago
Hi Oscar, I notice you use the HTML attribute "class" on all elements even when you don't assign any classes, why is that? Your HTML would be completely valid without them as well, and perhaps a little more readable.
What you could do to get a closer result to the design is to set the container width to less than 100%. Maybe 40? And apply a bit of box-shadow to match the design.
To avoid the Flash of Invisible Text (which results from loading the font and using it directly) you could use the font-display css property to change how the browser displays the font. Read more here: https://css-tricks.com/font-display-masses/
0@odpineroshPosted over 3 years agoHi @KL13NT and thank you so much for your comments. The empty class attribute is because I was working with Bootstrap's list-group-item. Later I took that off and forgot to delete the attribute.
I will have your advice in mind. Thank you.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord