Elisavet• 500
@elisavet12
Submitted
I'm a bit confused with this! Any comments or suggestions are welcome! :)
Stefan RIZEA
@JoyGHub
All comments
- Stefan RIZEA• 120
@JoyGHub
Posted
Hello Elisavet!
I would personally change the following things:
First, I would place the "Challange by..." paragraph somewhere near the bottom and color it in a way so that it's not distracting the user from the rest of the page.
Secondly, I would make it so that users can't select text / images. Of course, this is not a very important thing, but I like to add this touch if the page doesn't contain elements I really want the user to select. It makes the page look more professional.
I see you chose a different placement for the big image. I believe it looks great like this too.
Overall, it looks great. Keep it up!
- Stefan RIZEA
0 - Gökhan Ç.• 20
@gokhancerk
Submitted
I tried to practice my vanilla js and tailwindcss skills. Any feedback is welcome thanks.
Stefan RIZEA• 120@JoyGHub
Posted
Hello Gökhan!
The page looks amazing! But I would change two things about it.
First of all, in the three columns (Snappy Process, etc), I would add a little bit of padding between the text that's underneath.
Secondly, the hover effects for the social media buttons at the bottom are a little buggy. It only works when the cursor is exactly on the SVG.
- Stefan RIZEA
Marked as helpful
0 - Saniya Saher• 120
@saniyasaher20
Submitted
Hi, PLease help in this-> The focus and active psuedo class is working only after double clicking the rating button. but it should work on single click.
If I add "pointer-events: none;" to the button tag then the focus and active classes works fine but then react onClick event is not working. What shouldI do?
Stefan RIZEA• 120@JoyGHub
Posted
Hello Saniya!
The star in the circle above, and the numbers inside the rating buttons don't seem to be centered perfectly. Also, I wouldn't let the user submit without selecting a rating first.
Other than that, the component looks excellent!
Keep it up,
- Stefan RIZEA
Marked as helpful
0 - maia• 300
@maiaflow
Submitted
I wonder what would be considered the true "best practice" way to pass the rating variable through. I also wonder if I'm saying that right. Also, I wonder how the JS that Eric helped me with could be simplified. Lastly, I wonder what sort of solutions people came up with to prevent someone from pressing Submit until a rating had been chosen.
Stefan RIZEA• 120@JoyGHub
Posted
Hello Maia!
When it comes to disabling the Submit button until a user selects a rating, in this case, your Submit could start by being disabled until the user selects any of the rating buttons (until any of them has the "clicked" class). After that, the user is 100% going to have a button selected, no matter what, so you no longer have to disable the Submit button.
"Also, I wonder how the JS that Eric helped me with could be simplified." - Yes, they 100% can be simplified.
Overall, the component looks great! I like the radial-gradient you placed on it.
Keep it up,
- Stefan RIZEA
Marked as helpful
0 - Kate• 30
@unic0rnKate
Submitted
Open to any suggestions. Thank you! :)
Stefan RIZEA• 120@JoyGHub
Posted
Hi Kate!
The second paragraph's weight is too small so the text is hard to read, and the box-shadow you placed on the card is a little too strong. I would personally make it blurrier and drop its opacity a bit.
Also, the background color seems to be a little different.
Other than that, it looks great. Keep it up!
- Stefan RIZEA
Marked as helpful
0 - AhmedAlasyotY• 110
@Ahmed666313
Submitted
My Fourth challenge, I hope it's a true challenge. Adjusting the screens I had a problem with it ?
Stefan RIZEA• 120@JoyGHub
Posted
I think you uploaded the solution for the incorrect challange.
0
