Skip to content
OverviewSolutions
2
Comments
2
P
Josiel Soares da Silva Medeiros Lima
@JosielLima

All comments

  • Josiel Soares da Silva Medeiros Lima•90
    @JosielLimaPosted about 1 month ago

    Does the solution include semantic HTML? It is a challenge to do semantic HTML in React, we always forget about this detail. A good approach in the future is to create simple HTML to build the basic semantics, while thinking about what architecture you will use.

    Is it accessible and what improvements could be made? Yes. Excellent tab navigation.

    Does the layout look good on a variety of screen sizes? Yes.

    The only problem was the modal on mobile that stuck at the top. Is the code well structured, readable and reusable? Aim.

    Does the solution differ significantly from the design? No

    Marked as helpful
    0
  • Josiel Soares da Silva Medeiros Lima•90
    @JosielLimaPosted 3 months ago

    Great job! Your code is really readable and well-organized, which makes it much easier to understand and maintain.

    I have just two suggestions for improvement:

    Use of H1 tags: I noticed an excessive use of the <h1> tag. This can negatively impact the semantics of the page, especially in terms of accessibility and SEO. It would be good to review the use of headers to maintain the appropriate hierarchy.

    Using JSON for colors: The solution you implemented using JSON to store colors is innovative, but based on my experience, it’s not common to receive this type of information directly from the backend. A more traditional and perhaps more suitable approach would be to define these colors directly in the frontend, even if it slightly increases the verbosity of the code.

    Overall, the work is excellent! These are just suggestions to further optimize the solution.

    Marked as helpful
    0