Skip to content
OverviewSolutions
6
Comments
5
SITRAKA Tsimisaraka Joliot
@Joliot-TSIMISARAKA

All comments

  • SITRAKA Tsimisaraka Joliot•70
    @Joliot-TSIMISARAKAPosted about 2 months ago

    A great job ! I've just completed this project too, One little thing, it seems you have forgotten to add a hover effect on the add to cart button

    0
  • SITRAKA Tsimisaraka Joliot•70
    @Joliot-TSIMISARAKAPosted about 2 months ago

    The solution provided is already close enough to the design, it just lack some adjustments:

    • Try to use the 02 font families that came along with the project, it seems you've only used the Outfit and not the Young serif one for big headings,
    • Also, don't forget to take into account the mobile version of the project too, and make it reponsive, you can do that pretty easily with @media only screen and (min-width: 480px){} for mobile

    I'm no expert so I hope that my remarks have at least help you review your code and make you try harder again,

    0
  • SITRAKA Tsimisaraka Joliot•70
    @Joliot-TSIMISARAKAPosted about 2 months ago

    Is it not recommended to make your css code visible in the respository ? By the way, your solution looks like the exact copy of the design

    0
  • SITRAKA Tsimisaraka Joliot•70
    @Joliot-TSIMISARAKAPosted about 2 months ago

    I think that most of us, fellow learners here, forget clean the HTML page we start with in the project. Your solution here should've been perfect if centered right. When it comes to centering a single element inside a *body, like in this project, I usually make use of flexbox

    body {
   display: flex;
   align-items: center;
   justify-content: center;
   height: 100vh;
}
    0
  • SITRAKA Tsimisaraka Joliot•70
    @Joliot-TSIMISARAKAPosted 2 months ago

    From what I can see in your solution, the result slightly differs from the design ! I'm not too familiar with less/sass but I think that you should've centered the card right in the middle of the body. Try to set the height of the body to 100vh instead of 90vh, it should fix the problem

    0