This is my second project I need to improve on my css and mobile first approach. I do ok until its time to add media queries and figuring out what to change to make it mobile friendly I would appreciate any help on this issue
Johnnatan
@JohnnatanVAll comments
- @samuelsmith442Submitted about 3 years ago@JohnnatanVPosted about 3 years ago
Hey good job whit the challenge, i have some feedback for you.
-
The responsive view dont look complete because you put the max-width of the card in 450px you could use % to make it more adaptable to screen-sizes, one option to fix that is to use a div that wrap the card and give a padding that way you can keep the card inside the size of the screen.
-
One of the accesibility issues is that you have to use the heading tag in decendent order to keep a good practice, if you use a h1 tag the next one should be a h2.
-
For the other issue you need to wrap the footer section inside a footer landmark.
Keep the good job and keep learning.
1 -
- @JohnnatanVSubmitted about 3 years ago
New challenge whit methodology BEM and based in the mobile-first workflow
@JohnnatanVPosted about 3 years agoI'm going to check all right now thanks for the tips.
0