Social Proof challenge mobile first workflow

Community feedback

• 

  T

  Grace•30,990

  @grace-snowPosted about 3 years ago

  Hi

  This looks good

  Only small suggestions really

  • on mobile portrait the content is almost hitting my screen edges making it hard to read. It is caused by unnecessary min-width on the container that is wider than my mobile. It shouldn’t
  • essential to make the alt text blank on those star images so assistive tech and search engines ignore them
  • the “rated 5 star by” text definitely shouldn’t be h3. It’s not a heading for any content
  • optional but recommended to use figure and figcaption for the testimonial quote cards
  • always keep line height unitless like 1.5 or use %. Never any other unit
  • try to let things be the size they need to be based of content and padding rather than stating specific height. If you use height on boxes the solution will become less robust, as content will often be changed by someone else in real projects

  I can’t quite tell for sure without looking in a browser but based on things like min-width 720px at that media query I’s be concerned content might hit screen edges sometimes, and curious what will happen when all the widths of flex children are done in width (rather than max-width/flex-properties). It might be fine… I’d definitely want to check

  Good luck

  Marked as helpful

  0
• 

  Johnnatan•305

  @JohnnatanVPosted about 3 years ago

  I'm going to check all right now thanks for the tips.

  0