none
Jhoell Opeyemi
@JhoellOpeyemiAll comments
- @KaziSifatAlMaksudSubmitted almost 3 years ago@JhoellOpeyemiPosted almost 3 years ago
This is nice!
Here's a suggestion though:
- According to the design, the images should be above the text but yours are side by side on mobile ( I'm viewing from a 360px viewport ).
0 - @the-matheuslimaSubmitted almost 3 years ago
Any feedback will be appreciated.
@JhoellOpeyemiPosted almost 3 years agoReally nice work!
Just one suggestion though:
There's an horizontal scroll on mobile view
body { overflow-x: hidden; }
The code snippet above should fix it :)
Marked as helpful0 - @Srijan945Submitted almost 3 years ago
Checkout my code for the Challenge.
- @codein-looneySubmitted almost 3 years ago
Any feedback appreciated :)
@JhoellOpeyemiPosted almost 3 years agoGreat work!
You might want to remove the width you set on the card as the texts are breaking out in mobile view
Marked as helpful0 - @duncanwhyteSubmitted almost 3 years ago
Any feedback would be appreciated. Is the reverse margin an acceptable solution to the design of challenge ?
I would like some input on how to organise my code to be neat and organised as I hope to get a job one day as a junior frontend developer.
Any criticism will be well received.
@JhoellOpeyemiPosted almost 3 years agoNice work Duncan Whyte! One issue though. There's an horizontal scroll on mobile screens, you could fix that by adding overflow-x: hidden; to the body. And you might want to have a look at your report
0 - @cwus619Submitted over 3 years ago
I'm pretty happy with how this turned out, but any feedback on my use of CSS Grid and the breakpoints I've set is always much appreciated.
@JhoellOpeyemiPosted over 3 years agoThis looks great!
But between 1000px and 1150px screen sizes, the texts are busting out of their container (review div)
Nice work though!
0