
Roland Jethro Suyom
@Jeth0214All comments
- @FadilanoSubmitted over 1 year ago@Jeth0214Posted over 1 year ago
Hello @Fadilano , you need to omit the first slash "/" before the image source. It should be "images/image-equilibrium.jpg" not "/images/image-equilibrium.jpg". It is the file path issue on your GitHub.
Marked as helpful0 - @catherineisonlineSubmitted almost 3 years ago@Jeth0214Posted almost 3 years ago
Hi Catherine good job. Your solution was almost the same with the design. I just found an issue when I am clicking your "." button like this "9.96." . I can put 2 decimal point. I think maybe you can check if the value has already a decimal point when clicking the "." button then just return if it is has .
Marked as helpful3 - @ameer005Submitted almost 3 years ago@Jeth0214Posted almost 3 years ago
Hi @ameer, your solution was nice. These are things that I noticed.
- There is an issue on accessibilities based on the report. Try to use semantic element like main element as a container for your solution. Then, instead of div use section element to group some elements.
- In your bill input, I try to input the letter "e" and "-" and it accepted it. Try to add some validation to check if the input are number characters. Or use type ="number". Overall is nice looking solution.
Marked as helpful0