Skip to content
OverviewSolutions
15
Comments
3
Roland Jethro Suyom
@Jeth0214

All comments

  • Roland Jethro Suyom•365
    @Jeth0214Posted over 1 year ago

    Hello @Fadilano , you need to omit the first slash "/" before the image source. It should be "images/image-equilibrium.jpg" not "/images/image-equilibrium.jpg". It is the file path issue on your GitHub.

    Marked as helpful
    0
  • 👾 Ekaterine Mitagvaria 👾•7,600
    @catherineisonlineSubmitted over 2 years ago

    Hello, Frontend Mentor community! This is my solution to the Calculator App.

    I appreciate all the feedback you left that helped me to improve this project. I fixed the issues I had previously and added new features per your recommendation.

    I have done this project a while ago however if you are here and have any feedback, tips, or ideas to share, I will be more than glad to hear them out!

    Thanks

    Calculator App

    8
    Roland Jethro Suyom•365
    @Jeth0214Posted over 2 years ago

    Hi Catherine good job. Your solution was almost the same with the design. I just found an issue when I am clicking your "." button like this "9.96." . I can put 2 decimal point. I think maybe you can check if the value has already a decimal point when clicking the "." button then just return if it is has .

    Marked as helpful
    3
  • Roland Jethro Suyom•365
    @Jeth0214Posted over 2 years ago

    Hi @ameer, your solution was nice. These are things that I noticed.

    1. There is an issue on accessibilities based on the report. Try to use semantic element like main element as a container for your solution. Then, instead of div use section element to group some elements.
    2. In your bill input, I try to input the letter "e" and "-" and it accepted it. Try to add some validation to check if the input are number characters. Or use type ="number". Overall is nice looking solution.
    Marked as helpful
    0