Tip calculator app using sass

Community feedback

• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey good job completing this challenge

  Keep up the good work

  Your solution looks great however I think that the text for the reset button in the calculator needs more opacity in order to be visible

  In terms of accessibility issues simply wrap all your content between main tags

  I hope this helps

  Cheers

  Happy coding 👍

  Marked as helpful

  0

  ---

  

  Ameer Khan•360

  @ameer005Posted over 2 years ago

  @TheCoderGuru thank you for your valuable feedback 🙌 I'll definitely apply it

  0
• 

  Roland Jethro Suyom•365

  @Jeth0214Posted over 2 years ago

  Hi @ameer, your solution was nice. These are things that I noticed.

  1. There is an issue on accessibilities based on the report. Try to use semantic element like main element as a container for your solution. Then, instead of div use section element to group some elements.
  2. In your bill input, I try to input the letter "e" and "-" and it accepted it. Try to add some validation to check if the input are number characters. Or use type ="number". Overall is nice looking solution.

  Marked as helpful

  0

  ---

  

  Ameer Khan•360

  @ameer005Posted over 2 years ago

  @Jeth0214 thanks for the feedback 🙌 I'll learn more about semantic html

  0