Skip to content
OverviewSolutions
22
Comments
25
Jesús Alejandro Atao
@JesusAtao96

All comments

  • Jesús Alejandro Atao•970
    @JesusAtao96Posted almost 4 years ago

    Hello Luca Pizzarotti 👋

    Excellent work on this challenge 🎉🎉🎉.

    • On screen devices > 800px and < 1500px the landing does not look good.
    • The image is not resized correctly, using media query you can fix it.

    Just that and it will look excellent, Happy coding 😊.

    1
  • Karel Klečka•160
    @KlekarSubmitted almost 4 years ago

    One of the possible improvment I thought of is to load or display the later parts of the list when it's necessary (when scrolled to it) and I plan on doing some research on this and how it affects the performance. So if someone got some reading materials about that that he could provide to me I would be grateful.

    REST Countries with React

    1
    Jesús Alejandro Atao•970
    @JesusAtao96Posted almost 4 years ago

    Hello Karel Klečka 👋

    Excellent work on this challenge 🎉🎉🎉.

    Add on the body, header and your other elements with background-color transition: background-color .5s, now press the dark / light button and the background color change is smoother ✨.

    Happy coding 😊.

    1
  • Jesús Alejandro Atao•970
    @JesusAtao96Posted almost 4 years ago

    Hello nisma ahmed 👋

    Excellent work on this challenge 🎉🎉🎉.

    • On screen devices> 1100px the stars change size because you use% in the grid-template, try to use fixed values.

    Happy coding 😊.

    0
  • Eduard Garcia•50
    @GoatBassSubmitted almost 4 years ago

    Hello All!

    Just finished my second challengewith this amazing flag site! Gotta say it was a pretty tough one and some stuff drove me crazy, but I'm pretty happy with the result :D

    Be welcome to post any feedback, will be much appreciate it <3

    Have a nice day!

    JavaScript CSS3 HTML5

    1
    Jesús Alejandro Atao•970
    @JesusAtao96Posted almost 4 years ago

    Hello Eduard Garcia 👋

    Excellent work on this challenge 🎉🎉🎉.

    • The header and the filters are not centering on screen devices > 1450px, try to fix it.

    • Add on the body and the header transition: background-color .5s, now press the dark / light button and the background color change is smoother ✨.

    Happy coding 😊.

    1
  • Jesús Alejandro Atao•970
    @JesusAtao96Posted almost 4 years ago

    Hello Wilder Rincon 👋

    Excellent work on this challenge 🎉🎉🎉. Just add transition: background .5s on the body and the header class, now press the dark / light button and the background color change is smoother ✨.

    Happy coding 😊.

    1
  • Jesús Alejandro Atao•970
    @JesusAtao96Posted almost 4 years ago

    Hello Abiodun Olunu 👋

    Excellent work on this challenge 🎉🎉🎉.

    Try to integrate a debouce for the input search, this makes the request be called when the user stops typing. Currently in your solution for each letter written a request is being made and that is bad for a real project,.

    More info

    Your backend will appreciate it very much ✨.

    Happy coding 😊.

    2
  • Yagiz•140
    @tosbaaSubmitted almost 4 years ago

    I used sass for the first time. It may be a little bit much css and media queries. I'm waiting for the feedbacks. Thanks !!

    HTML CSS and SASS

    3
    Jesús Alejandro Atao•970
    @JesusAtao96Posted almost 4 years ago

    Hello Yagiz 👋

    Excellent work on this challenge, if you want to improve your CSS code, I recommend using BEM (Block, Element, Modifier) ​​methodology.

    For more information

    Happy Coding 😊.

    3
  • Jesús Alejandro Atao•970
    @JesusAtao96Posted almost 4 years ago

    Hello CodeSmitty 👋

    Excellent work on this challenge 🎉🎉🎉. Just add transition: .5s background color on the body, now press the dark / light button and the background color change is smoother ✨.

    Happy coding 😊.

    0
  • Jesús Alejandro Atao•970
    @JesusAtao96Posted almost 4 years ago

    Hello Djordje Stevanovic 👋

    Excellent work on this challenge 🎉🎉🎉. Only add transition: background-color 1s in the body and todo-form class, In header class add transition: background 1s, now press the dark/light button and enjoy the magic ✨.

    Happy coding and Happy new year 😊.

    0
  • Anthony Gonzales•90
    @apatrickgSubmitted almost 4 years ago

    Hey all,

    Any suggestions or general feedback would greatly be appreciated. Thanks

    Insure Landing

    1
    Jesús Alejandro Atao•970
    @JesusAtao96Posted almost 4 years ago

    Hello @apatrickg 👋

    The layout breaks on devices larger than 1500px, try to use a fixed width so that the elements do not overflow.

    Happy new year and keep coding 😊.

    0
  • SHIVAM MINA•10
    @shivam-minaSubmitted almost 4 years ago

    I m beginner , my output seems right but my code seems little bit less readable. I will try writing better code in upcoming challenges. if u saw my work , any comments are welcomed

    Social Section using HTML , CSS , Bootstrap

    3
    Jesús Alejandro Atao•970
    @JesusAtao96Posted almost 4 years ago

    Hello @shivam-mina 👋

    Excellent work in this challenge. I would recommend you learn about CSS Grid and Flexbox.

    Happy coding and Happy new year 😊.

    1
  • AndyBeable•120
    @AndyBeableSubmitted almost 4 years ago

    Hi Guys,

    This project started off well, but I ran in to a few problems which have been driving me crazy!

    Would love some advise on some of the following points:

    • On tablet vp - the ctas in the plan sections. I couldn't work out how to position them at the bottom of the left hand column, without using absolute positioning. When I did this, it then meant that I had to create lots of mqs as the screensize changed, as the ctas were moving up.
    • Countdown numbers on desktop/tablet - should be a really simple fix but I can't get the numbers to centre for some reason!
    • Form styling - was a bit lost with how to style the inputs and particularly the selects.
    • Background-images - again, struggled with these as absolute positioning meant they keep moving on different screensizes and I wasn't sure of the fix.

    Cheers

    Officelite using scss, flexbox and js

    1
    Jesús Alejandro Atao•970
    @JesusAtao96Posted almost 4 years ago

    Hello @AndyBeable 👋

    countdown numbers are not centered because they have left and right padding, try using a fixed width.

    for example:

    .countdown__item {
    display: flex;
    flex-direction: column;
    justify-content: center;
    max-width: 110px;
    width: 70px;
    padding: 2.5rem 0;
    text-align: center;
    background-color: #333950;
    border-radius: 5px;
}

    Vote up if I helped you.

    Happy new year and keep coding 😊.

    2