Skip to content
OverviewSolutions
4
Comments
2
James F. Ciskanik
@JamesTheLessFC

All comments

  • James Le-Goffβ€’310
    @jameslegoff92Submitted about 3 years ago

    Hi front end mentor community πŸ˜„,

    This is project #3 and it definitely went smoothly. Got the website to look good on mobile (portrait and landscape), and desktop, as well as successfully implementing the active states. I had to use inline CSS styling to get the outlines of the input element to be red when an error was made. I know that CSS styling should be confined to our stylesheets but this seemed like the simplest way to get the desired effect. Did anyone do it another way?

    Any feedback in regards to the readability of my code would be greatly appreciated. πŸ‘πŸ½

    Happy coding! πŸ˜„

    Responsive Web Form built with - HTML5, CSS3(Flexbox), JS, SASS, BEM

    2
    James F. Ciskanikβ€’200
    @JamesTheLessFCPosted about 3 years ago

    Hi @jameslegoff92, Nice job on this! To change the styles of your input element when there is an error present (without using inline styles), you could create a class for inputs with errors and apply the class when an error is found. Something like this:

    //stylesheet
input.errors {
  outline-color: red;
}
//validator function
document.getElementById("email_input").classList.add("errors");
    1
  • Purushotham Sirasapalliβ€’30
    @purushotham91Submitted about 3 years ago

    This is my second challange on front end mentor. I would like to know if there are any better way to name my class names. Most of the time i am stuck in deciding the class names for the elements. Is there any way or practice to write the class names without wasting much time or does it get better with more practice?

    Responsive design, CSS Flex box

    2
    James F. Ciskanikβ€’200
    @JamesTheLessFCPosted about 3 years ago

    Hi @purushotham91, Nice job on this! I remember wondering the same thing. I've found that naming classes does get easier with time (I don't spend more than a few seconds thinking about it now.) However there are a few things I do keep in mind. When a project is especially complex and you come back to it after a break, you'll thank yourself for giving your classes names that make sense and are easy to tell what they are. For instance if it's a div element functioning as a wrapper/container, include that in the name (i.e. "gallery_container"). It's also a good idea to be consistent with your naming, like sticking to camelCase or using underscores to separate words. Or if you're giving class names to your buttons, you could do something like "submit_button" and "delete_button", etc. Naming these "button_1" and "button_2" will be confusing once you have a lot of classes in your project. Above all, it should be easy for someone reading your code to figure out what the class name refers to.

    Marked as helpful
    0