Skip to content
OverviewSolutions
28
Comments
5
Udeh Ifeanyi
@Ifescohub

All comments

  • Erkin•50
    @ErkinNSubmitted over 2 years ago

    I am a newbie in the area, please give me any feedback. I would appreciate it, thank y'all !!!

    HTML,CSS

    4
    Udeh Ifeanyi•520
    @IfescohubPosted over 2 years ago

    @ErikN Your work is well done. It is very close to the project.

    Regarding your report, You are getting some of the reports because you wrapped everything in a div tag. To set that, wrap your "container" and "attribution" class in a main and footer tags respectively. I.e

        <main class="container">
         //other div
     </main>
    <footer class="attribution">
           //Your text
     </footer>   ```

Happy coding.
    Marked as helpful
    0
  • Udeh Ifeanyi•520
    @IfescohubPosted over 2 years ago

    Hi @Abdussalam, it seems you posted a wrong live site for this project. The directory on GitHub seems right, but the live site is a wrong one.

    0
  • promise•520
    @ugochukwuuuSubmitted over 2 years ago

    for some strange reason i struggled with making the card centered on the page, so I would very much appreciate it if someone could help me with that

    css flexbox

    2
    Udeh Ifeanyi•520
    @IfescohubPosted over 2 years ago

    Very great work you have done here. It looked closely like the design. Here are my observations regarding your challenge. (I'm also learning though).

    Try to add the following to your body in the CSS in order to center it well: height: 100vh; display: grid; place-items: center;

    -And also regarding your report, try to place your main card class in "main" rather than "div". Like:

    <main class="card"> You can place other divs inside this </main>

    -And lastly, your attribution class should be in a "footer" tag and not "div" tag. I believe this will help to solve the report issues. Happy coding.

    0
  • Udeh Ifeanyi•520
    @IfescohubPosted over 2 years ago

    The link you submitted for your site is not the live site link from GitHub. Try submitting again with the live site link given by GitHub.

    Marked as helpful
    0
  • Udeh Ifeanyi•520
    @IfescohubPosted over 2 years ago

    A very nice design here. So close to the design. There are a few observations I have regarding your code. first, try changing the "div" to "main" as this will probably solve the reported issue. and secondly, try making use of a heading tag like "h1" or "h2" for your heading (Sedans, SUVs, and Luxury). This will go a long way to solve your HTML report issue.

    Marked as helpful
    1