Skip to content
OverviewSolutions
2
Comments
3
IAmOrale
@IAmOrale

All comments

  • Fafel•140
    @FafellSubmitted 8 months ago
    What are you most proud of, and what would you do differently next time?

    I didn't use any help! I did everything myself :D

    What challenges did you encounter, and how did you overcome them?

    The problem I had was styling the graphics/img, I think it doesn't scale perfectly to the mobile version, especially the img height.

    What specific areas of your project would you like help with?

    I thought I still had a problem using the correct units.

    Blog-preview-card

    1
    IAmOrale•60
    @IAmOralePosted 8 months ago

    Looks awesome! :)

    I believe adding a line height of 1.5 to the body styling would both make it more similar to the original and would also be best practice. Keep it up!

    Marked as helpful
    1
  • enoxDev•40
    @enoxSutrisnoSubmitted 8 months ago
    What are you most proud of, and what would you do differently next time?

    Implementation of HTML CSS learning outcomes into projects

    What challenges did you encounter, and how did you overcome them?

    learn css

    What specific areas of your project would you like help with?

    clean code on css maybe

    QR Code Component

    2
    IAmOrale•60
    @IAmOralePosted 8 months ago

    Looks great overall :)

    A few small things I noticed:

    • text padding and margin is a bit off
    • border-radius on the image a bit off as well
    • the <p> didn't get the font size as stated in the style guide
    • the orignal container has a slight box-shadow on it, it's subtle but it's there :)

    I think these small changes might bring it even closer to being spot on. Keep it up!

    Marked as helpful
    0
  • IAmOrale•60
    @IAmOralePosted 8 months ago

    Overall looks great :)

    A few small things I noticed -

    • The background color is not according to the style guide.
    • The font size for the header is bigger than the styling guide's, I believe this is what's causing it to be 3 lines and not 2.
    0