Skip to content
OverviewSolutions
3
Comments
6
Svetlana Jokic
@Holllyyyy

All comments

  • Svetlana Jokic•90
    @HolllyyyyPosted over 2 years ago

    Hii @waldekglaz, great job! :3

    Marked as helpful
    0
  • Dorian Arriaga•20
    @dorianarriSubmitted over 2 years ago

    Decided to fully get into web development last month so this is my first challenge. Any tips and advice are much appreciated.

    QR Code Component

    4
    Svetlana Jokic•90
    @HolllyyyyPosted over 2 years ago

    Great job @dorianarri :3 You can add box-shadow if u would like it.

    1
  • Svetlana Jokic•90
    @HolllyyyyPosted over 2 years ago

    Hello @wqais, great job, well done! :3 I would recommend you for large screens to use *{paddin n margin 0, box-sizing border box} that will be applied on all ur elements... One tip: try to always make a folder for CSS, and inside that folder to put CSS files, it's much easier for other devs to reading your code. :3

    Marked as helpful
    0
  • Francis Wilson•20
    @ApprentixxSubmitted over 2 years ago

    My first challenge on here would like to hear some feedback on how well this in terms of comparison. Was built in an hour and 15 minutes

    QR Code landing page

    1
    Svetlana Jokic•90
    @HolllyyyyPosted over 2 years ago

    Great job, be careful about accessibility issues... Always be sure to include <main> instead u putting div as a first step. Also, every page should have h1 first then h2, etc... On small devices, I would need to move left-right to find where is it, n on the larger screen, it's not centered. I would suggest you flexbox for centering, and to avoid positions here. Try to use %, rem, em instead of px, cause px are absolute lengths... Good luck.

    0
  • Svetlana Jokic•90
    @HolllyyyyPosted over 2 years ago

    Great job! As you can see around ur picture, there's a little blue color, so put the background color white. :3

    0
  • Aziz Moe•400
    @a2uuzSubmitted over 2 years ago

    Hi all, Thank you for taking time to review my code!

    If there is anything I can improve. I appreciate any comments, thank you

    qr-code component

    1
    Svetlana Jokic•90
    @HolllyyyyPosted over 2 years ago

    Hello, great job! :3 You can change h3 to h1 cause of accessibility, also <div class="parent"> should be actually <main class="parent"> also cause of accessibility so you will remove accessibility issues. You can add some box shadow for better design.

    Marked as helpful
    0