Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • @samuelbm12

    Submitted

    What are you most proud of, and what would you do differently next time?

    I am Proud of the fact i did the project without any help and next time i would add a bit of JavaScript to it

    What challenges did you encounter, and how did you overcome them?

    I really did not have any encounter

    What specific areas of your project would you like help with?

    Just how to use Grid, I know it is not related but i would like to know on my grid

    @Hiraeight

    Posted

    Good Job! It is nice to see a fellow coder is making progress. I would like to suggest some small ways to make your solutions to level up.

    • Media Queries: Introduce media queries to adjust styles based on the screen width, ensuring the layout is optimized for small, medium, and large devices.
    • Text and Font Size Scaling: It is better to use responsive text sizing with rem or viewport-based units like vw or vh so that fonts adjust with screen size. A friend named Fraser Jubb suggested to me this video and it helped me a lot. He did an amazing job applying these practices.
    • Using a <main> tag inside the <body> of your HTML is a best practice because it clearly identifies the main content of your page. This helps with accessibility and improves how search engines understand your content. - Steven Stroud

    Amazin job! Keep learning and keep improving!

    0
  • @Hiraeight

    Posted

    Hello! your solution looks great! I just have one suggestion, I noticed that when I view your solution in small mobile view, 320px width to be exact, the yellow background stopped covering the whole background. You can fix that by applying the color in the body instead of in the hero class.

    ex. body { background-color: hsl(47, 88%, 63%); {

    but then again, I'm quite new so maybe there is a better solution for this. If so, I would love to know too. But overall, I can say that your solution passed. Keep it up!

    0
  • @Hiraeight

    Posted

    Your design has additional designs that made it so much better. It looked nice when you show the border and gave your h1 a shadow. Your CSS is very clean too. Keep it up and continue to inspire others.

    0