Skip to content
OverviewSolutions
9
Comments
2
Hisham Abdelalem
@HeshamAbdelalem

All comments

  • Hisham Abdelalem•150
    @HeshamAbdelalemPosted over 1 year ago

    Great Work 🎉

    Your code is very clean ;)

    • the img tags got an alt attribute with fallback text :)
    • the css file is amazing
    • the media query also clean
    • using css variables like a pro
    • I really like your solution

    keep going bro

    1
  • Hisham Abdelalem•150
    @HeshamAbdelalemPosted over 1 year ago

    Nice work bro, you made it

    • At first sight, I noticed you omitted the alt attribute and didn't give it any value, I suggest always adding alternative text to your images

    • padding between your elements also will make it fancy, modern, shiny and the most important Easy to Read :)

    • <div class="container"> the div tag could be replaced with the main tag to make it semantic and to improve the accessibility rules

    I hope you find this helpful ;), Great Work

    Happy coding

    0