Product Card

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  COMPONENT MEASUREMENTS 📐:

  • Use min-height: 100vh for main instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation

  ---

  • For example; if we set height: 100vh then the main will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the main will start at 100vh, if the content pushes the main beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  1

  ---

  

  Lucas Vieira Veras•50

  @lucavieiraPosted over 1 year ago

  Thanks for the help, I'll review and make the necessary changes. Thank you for the explanation.

  @0xAbdulKhalid

  0

  

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Glad you found it helpful @lucavieira ! 🤠

  1
• 

  Hisham Abdelalem•150

  @HeshamAbdelalemPosted over 1 year ago

  Great Work 🎉

  Your code is very clean ;)

  • the img tags got an alt attribute with fallback text :)
  • the css file is amazing
  • the media query also clean
  • using css variables like a pro
  • I really like your solution

  keep going bro

  1

  ---

  

  Lucas Vieira Veras•50

  @lucavieiraPosted over 1 year ago

  Thank you very much, I am very happy with the comment. @HeshamAbdelalem

  1