It would be so appreciate if you could see my codes and make code review. I am proud of myself for implementing design part, but not for the cleanliness of code.
Ch. Hassan
@HSN-StudioAll comments
- @yaungheinSubmitted about 3 years ago@HSN-StudioPosted about 3 years ago
Hi, Good evening. I'm really impressed to see your work especially that skeleton loading part is amazing. I will definitely look at your code tonight :) I'm currently implementing the mobile version of this project and I'm almost done with homepage. You can have a look at it at https://hsn-studio.github.io/countries/ Feel free to comment :)
Regards Hassan
0 - @santu369Submitted about 3 years ago
Hi Everyone,
Used React, SCSS and Bootstrap for creating the landing page. I've not used the icons for hamburger menu instead used CSS for creating the same effect.
Appreciate any suggestions for improvement.
Thanks, Shiva
- @codernineteenSubmitted about 3 years ago
I had a issue with leaflet API. Whenever i tried putting new domain with reload, There were always error of Container already initialized. I tried to figure out this problem during few hours, but i couldn't solve this eventually. If there is someone who fully completed this challenge, Pls give me feedback of my ipFinder.js code
@HSN-StudioPosted about 3 years agoHi, you have done an amazing job. I have also completed the same challenge yesterday. 🙌🏻 The leaflet issue "container already initialized" occurs because you are trying to recreate the instance of map with each request. First time as the map is not already there so it initializes, but then you just don't have to initialize it again you just have to navigate using setView or flyToPos methods. I have experienced this issue in React and what I did is initialized the map only once, then used the whenReady prop to create an instance of it. I have then applied the flyToPos method on that instance using life cycle method updating the position or coords each time an ip is entered and hence only the flyToPos method execute. Map is not initialized with each request. You can also see my github code to seek help. Hopefully it is clear enough, feel free to ask me if needed.
Best Regards Hassan
1