Is it better to set a fixed width and height of the card rather than set it relatively to its inner content size like min-content? I didn't add media queries because it's still good in mobile screen thanks to flexbox.
Gulz
@GulzhubAll comments
- @zafiramdhaniSubmitted almost 2 years ago@GulzhubPosted almost 2 years ago
Looks great. Try including a h1(level one heading) to avoid the accessibility issue. You can replace the h5 with h1 heading and then customize it as per your requirement through CSS. Always try to pass the accessibility report in your projects. Hope I was helpful. ;)
2 - @AGutierrezRSubmitted almost 2 years ago@GulzhubPosted almost 2 years ago
Looks great on desktop but the mobile view needs to be optimized as the content seems to go out of the page when viewed on mobile. Moreover, the footer seems to interfere with the main content in mobile view. Try adding media queries for 375px and 1440px. These are fine for the current level of project.
1 - @SvprnceSubmitted almost 2 years ago
Check Out The code and help me to write better code from this 😊
@GulzhubPosted almost 2 years agoThe site looks great for mobile layout, Prince. However, you still need to limit the width for desktop layout as the card looks very big in the desktop view. I recommend reducing the width of the class "qr" or else you could use media queries too for limiting the card size. Hope it helps. Keep coding, brother.
Marked as helpful1 - @julius-tamaleSubmitted almost 2 years ago@GulzhubPosted almost 2 years ago
It looks really good and great work in centering it but I think you should give a certain size to the rows of the grid like you did with the columns because the content seems to overflow and cut off at around 1024px when we reduce the size from 1440px. Try adding a grid-template-rows to the main container in the media query(> 900px).
Hope I was helpful.
Marked as helpful1 - @BajuXSubmitted almost 2 years ago@GulzhubPosted almost 2 years ago
Hey Nuva The project looks good but I think you have used the wrong color on the "per month" text and also on the background which is why it is difficult to read the text. Use the light gray color provided in the style guide.
1