Responsive QR Code Component using Flexbox

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some other suggestions about your code that might interest you.

  CSS 🎨:

  • The width works with min-content due to the width (250px) of the image, and on small screens its component fortunately does not touch the edges. Keep in mind that using that value you will never be able to have total control over the width of the component, even so, if your component were larger and your image were equally larger, it is most advisable to use a fixed max-width on the component and use width: 100% on your image so that it is resized.

  Alt text 📷:

  • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article. 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  1
• 

  Gulz•110

  @GulzhubPosted almost 2 years ago

  Looks great. Try including a h1(level one heading) to avoid the accessibility issue. You can replace the h5 with h1 heading and then customize it as per your requirement through CSS. Always try to pass the accessibility report in your projects. Hope I was helpful. ;)

  2
• 

  Ahmed Mahrous•980

  @AhmedMahroussPosted almost 2 years ago

  good jop my bro Congrats on completing your first challenge!🎊🍻If you have any questions or need further clarification, feel free to reach out to me. Happy Coding! 🎆🎊

  1