Skip to content
OverviewSolutions
16
Comments
3
Girish Chandra banua
@Girishbanua

All comments

  • Girish Chandra banua•190
    @GirishbanuaPosted about 2 months ago
    0
  • Girish Chandra banua•190
    @GirishbanuaPosted almost 2 years ago

    Hey Buddy!, Girish here,

    I just reviewed your solution and wanted to help you with some tips, hope it helps you improve your code.

    1. The error message that is to be displayed beneath the input box does not stick to the place on different view size. I found that, this might be because of the non-styling of the Javascript element that you have created and appended.
    • What you can do instead is, just place a <p> element with the error message in your HTML, its not an issue if you add something that is required but not provided.

    <div class="input" id="div">

    <input id = "input" type="email" name="email" placeholder="Your email address" required>

    <p id="errorMessage"> Please provide a valid email address </p>

    </div>

    • Now you can stylize it in the css and with the help of 'id' attribute you can apply javascript too.
    1. Also I would recommend not to use percentages every where, they should be use only with elements whose position is set to "absolute" . Instead you must use "rem" for margins and padding.

    padding: 1rem

    1. You may ask me with anything related to this and I would be really happy to help. You can refer to my solution here- https://girishbanua.github.io/Ping-coming-soon/
    Marked as helpful
    0
  • Girish Chandra banua•190
    @GirishbanuaPosted almost 2 years ago

    Just modified some css stylings and added a button at the bottom of the card to change the theme. Also added some css animations to make it look satisfying. This was a very basic one but while improving it I learnt a lot of things, inclding javascript

    0