Skip to content
OverviewSolutions
14
Comments
2
P
Giorgi Khaburzania
@GioKhabu

All comments

  • Patrik Holler•50
    @hollepatSubmitted 9 months ago

    Hi I have problem setting the app for GitHub pages. When I run npm run deploy ("deploy": "gh-pages -d build") it says this Error: The pattern in the "src" property didn't match any files. at Object.publish (/Users/patrikholler/workspace/age-calculator-app-main/node_modules/gh-pages/lib/index.js:111:7) at /Users/patrikholler/workspace/age-calculator-app-main/node_modules/gh-pages/bin/gh-pages.js:12:13 at new Promise (<anonymous>) at publish (/Users/patrikholler/workspace/age-calculator-app-main/node_modules/gh-pages/bin/gh-pages.js:10:10) at /Users/patrikholler/workspace/age-calculator-app-main/node_modules/gh-pages/bin/gh-pages.js:140:12

    Age calculator app in React

    2
    Giorgi Khaburzania•350
    @GioKhabuPosted 9 months ago

    Hello Patrik,

    Try to follow these steps: https://github.com/gitname/react-gh-pages

    I use it as a guideline every time I want to deploy React on GitHub.

    0
  • Giorgi Khaburzania•350
    @GioKhabuPosted 9 months ago

    Hello Eftimie,

    Nice work, functionality works perfectly. I would just suggest few points:

    1. First of all for inputs you can add placeholders like it is in the initial design DD, MM, YYYY.
    2. You also can wrap all inputs with the "form" element so on submit when user clicks enter on the keyboard it will calculate results not only on the click handler.
    3. For class='input-flex' you can just have border-bottom property so it will have just border on the bottom.
    4. To align the button properly you can add position: absolute and to its parent on class='input-flex' position relative. With that you can place the button anywhere you would like with the properties: top, left, right, bottom.
    5. Semantically it is recomended to have only one h1 element on page and others you can make as h2s.
    6. Finally, you can have more margin with results and labels and also make text more bold.

    Wish you success with other projects.

    Marked as helpful
    0