Skip to content
OverviewSolutions
36
Comments
4
George Kandelaki
@GeorgeKandelaki

All comments

  • George Kandelaki•610
    @GeorgeKandelakiPosted about 2 months ago

    Hello fellow Georgian, I am glad to meet someone who is from my country. The Calculator logic is Wrong, It doesn't Calculations, where first the Numbers should be multiplied and then added to each other. I would advice you to use eval() function. Except that everything in design is on point. Nice meting you!

    1
  • Thomas•450
    @TomSifSubmitted about 2 months ago
    What are you most proud of, and what would you do differently next time?

    As someone suggested I used the 'block element method' to name my css classes and followed the rules as best I could to provide a project close to industry standards. I annotated my code to make it more understandable by others, I admit I don't really know what is customary to do at the moment.

    What challenges did you encounter, and how did you overcome them?

    Basically nothing special, I just encountered a problem with the loading time of the ttf font, which for some reason I don't know took almost 3.5s to load, so I downloaded the same font in woff2 version and that solved the problem.

    What specific areas of your project would you like help with?

    As said before, on small simple projects like this my goal is to apply as much as possible, the advice and uses of the industry, being totally self-taught, I hope to succeed by doing these exercises to acquire necessary reflexes, and essential to work in a company. So all advice, criticism and resources are welcome. Thank you for taking the time to read my code and leave me a little comment :)

    Front-end_mentor_preview_card_component

    1
    George Kandelaki•610
    @GeorgeKandelakiPosted about 2 months ago

    Really Liked the Solution, Also I am impressed by how precise the solution is to design. First thing I notices was buttons hover state, I would advice you to add transition property on buttons hover effect. other than transition everything is perfect, Great Solution!

    Marked as helpful
    1
  • Daniel 🛸•44,310
    @danielmrz-devSubmitted 5 months ago
    What are you most proud of, and what would you do differently next time?

    🛸 Hello FEM Community! I'm Daniel and this is my solution for this challenge! 😊

    🛠️ Built with:

    • HTML 🧾
    • SASS 🎨
    • TypeScript 🆕
    • Mobile first workflow approach 📲

    This project is incomplete. I'm posting it because I wanna see how other developers approached the same issues. The design wasn't a problem but the logic for adding new comments and replying existing ones was a bit difficult for me. Maybe it's because that was the first time I tried using TypeScript on a project, I don't know. I intend to keep on studying to learn how to solve the problems I couldn't during this challenge.

    Well, although I'm a bit frustrated for not being able to fulfill all the challenge requirements, I'll keep learning until I am.

    If you have any suggestions on how I can improve this project (specially about the logic), feel free to leave me a comment!

    Feedback welcome 😊

    Interactive comments section built w/ TypeScript and SASS

    2
    George Kandelaki•610
    @GeorgeKandelakiPosted 2 months ago

    Hey daniel, I am working on this project too, I can't seem to figure out how to like and dislike, but I think finding comments isn't working because you didn't add the replies array in data.json. Try that because when I saw the function findCommentById everything was fine.

    0
  • George Kandelaki•610
    @GeorgeKandelakiPosted 3 months ago

    One thing I saw was, that you had specified the height and the width of the body itself, by doing that it is not aligned properly. I would Advice you to remove those styles from the body, and add it to child container, which holds the content.

    0