Interactive comments section built w/ TypeScript and SASS

Community feedback

• 

  haquanq ®️•1,585

  @haquanqPosted 4 months ago

  Hello Daniel 👋 Nice work on the solution

  ✍️ This is my opinion on your solution:

  • textarea can use resize: none for better control of it's behaviors when users auditing comments (maybe we don't want them to change the input size but i'm not sure)
  • The background-color of the body is a bit darker than the design

  ✍️ About logic for interacting with comments, it can be difficult if you are overthinking about the best practices for it. For me, since i'm also working on this challenge i have figured out some rules for my own logic:

  • When adding or replying (create a new comment), comment can only have replyingTo of the person who "own" the comment that users have clicked reply and made a new comment replying to it. Comment's timestamp can be implemented while using toLocaleDateString() to display proper format and storing the Date object in data. We can improve this further by having our own functions to translate each Date of the comment to a relevant format (ex: 1 week ago, 3 months ago) by comparing each days, months (when the comment is older than 1 year then toLocaleDateString() can be used).
  • When editing existed comments, users can not change the replyingTo but only the content

  ✍️ So there are still many other possibilities based on how you want to implement the data structure for comments:

  • Unlimited comment nesting (like Reddit)
  • Users can type @ in the input and a list of users in the comment section will popup to choose to reply to or to make a reference to them (meaning the @person can appear anywhere in the content). The same thing applies to editing comments.
  • For each comment users can only increment the score only once

  Hope this help 🙏

  2

  ---

  

  Daniel 🛸•44,250

  @danielmrz-devPosted 4 months ago

  @haquanq Thanks for your feedback.

  Like I said, the project is incomplete. I spent too much time on it and still couldn't figure it out how to address the issues you've mentioned and others.

  Since I was using TypeScript for the first time, I was not sure about the best approaches for the issues I had, so I posted it like this so I'm able to visit the challenge hub and see how others approached them.

  Again, thanks for the feedback. I'll consider what you said when I refactor the code. 🙋🏽‍♂️

  0

  

  Saul Gabriel Aranguren•320

  @saularangurenPosted 3 months ago

  @haquanq Greetings friend, please help me see my projects, your opinion would be an honor.

  0

  

  haquanq ®️•1,585

  @haquanqPosted 3 months ago

  @saularanguren Greetings, are you replying to me or Daniel?

  0

  

  Saul Gabriel Aranguren•320

  @saularangurenPosted 3 months ago

  @haquanq you bro

  0
• 

  George Kandelaki•610

  @GeorgeKandelakiPosted about 2 months ago

  Hey daniel, I am working on this project too, I can't seem to figure out how to like and dislike, but I think finding comments isn't working because you didn't add the replies array in data.json. Try that because when I saw the function findCommentById everything was fine.

  0