Paulina• 350
@testerium
Submitted
The project took me about 2 hours to complete. It is responsive - desktop and mobile version. I am a beginner with JavaScript, so this part was the most difficult for me to implement. Any feedbeck welcome :)
Gabriel Ruiz Varela
@GabrielRuizVarela
All comments
@GabrielRuizVarela
Posted
Hey, nice work! A couple of things I would add is parsing the json file directly and getting the maximum from that and not manual. Here an article that can be useful: https://developer.mozilla.org/es/docs/Web/JavaScript/Reference/Global_Objects/JSON/parse
P.S.: I like your the clarity of your code.
Cheers!
1- Molhem Marawi• 80
@ispirar2
Submitted
Any advices is welcome
@GabrielRuizVarela
Posted
Hey, nice work, I’m curious about why you choose to use transform: translate to position items. Is there any drawbacks?
0 - Arn.28• 90
@arn28
Submitted
About best practice, is it ok to use only flexbox to built complements? or when a grid display is more useful than flexbox?
@GabrielRuizVarela
Posted
Nice work! Personally I like to work with grid, I feel it give me more flexibility, but feels overkill sometimes. I think it comes down to preference but I’m curious how it’s like in a professional environment. This is a great article that goes more on to detail on the subject https://css-tricks.com/quick-whats-the-difference-between-flexbox-and-grid/
Marked as helpful
1
