Any feedback appreciated
Gabriel de Freitas Laminas
@GabrielLaminasAll comments
- @Katja721Submitted over 2 years ago@GabrielLaminasPosted over 2 years ago
Hello, nice work. I prefer h1 to div in 'Order Summary' text. Because it's more semantic than div. I think if you add a div below the 'illustration hero' img and put the rest of the content inside it. This is nice to work with padding. Look at:
<div class="container__info"> <h1> Order Summary</h1> <p class="description"> You can now listen to millions of songs, audiobooks, and podcasts on any device anywhere you like! </p> <div class="price"> <img src="./images/icon-music.svg" alt="music icon"> <div class="price-center"> <p class="plan">Annual Plan</p> <p class="year-price"> $59.99/year</p> </div><a href="#" class="change"> Change</a></div>
<div class="payment"> <a href="#"> Proceed to Payment</a> </div><a href="#" class="cancel"> Cancel Order</a>
</div>0 - @GabrielLaminasSubmitted almost 3 years ago
If you'd like feedback on my code, please add your questions below. Thanks!!
@GabrielLaminasPosted almost 3 years agoThanks for your feedback it's so important for me. I am going to watch this video.
0 - @erickamae-mateoSubmitted about 3 years ago
Any comments and suggestions are highly appreciated. Please view my Repository and look into my codes that needs improvement.
@GabrielLaminasPosted about 3 years agoHello there. In the main content the button view plan is not click because a bg-pattern-intro-left-desktop is over it and the same problem is happening how we work button with bg-pattern-how-we-work-desktop over it. I think you must add z-index in these buttons and check them in diferents breakpoints.
Marked as helpful0