Skip to content
OverviewSolutions
31
Comments
16
Foued
@Foued80

All comments

  • Foued•655
    @Foued80Posted over 2 years ago

    Very nice well done :D

    0
  • Jibreel•300
    @jibreel1Submitted over 2 years ago

    This project really helped me with the basic concepts of React. Your feedbacks are highly welcome.

    E-commerce product page

    1
    Foued•655
    @Foued80Posted over 2 years ago

    Hi, Jibreel great work for this challenge

    there is an issue with " + " it calls a function that increment "counter" that's ok but it is not supposed to show the quantity on the cart bdge (top right screen) untill you hit the "add to cart" button.

    0
  • Paula Isabel•230
    @paulaxisabelSubmitted over 2 years ago

    Hello everyone ! 👋

    Here is my solution for this challenge. Let me know your thoughts and feedbacks on this. Thanks!

    Loopstudios Landing Page

    2
    Foued•655
    @Foued80Posted over 2 years ago

    Great job Isabel, the animations are great!

    0
  • Holat•640
    @HolatSubmitted over 2 years ago

    I decided to use sass and found out its very easy to use for projects like this sass allows nesting and importation of different scss files into one so it makes it easy to partition website sections. Also followed through MRZ.Code.Manufacture on youtube it was a long one. But yes i finished it. Ill love feedbacks on better ways it could have been done.

    Thanks

    ecommerce page

    1
    Foued•655
    @Foued80Posted over 2 years ago

    hi, geat work.

    on desktop view when hovering over navbar links i can see the border-bottom shifting due to the boxsizing property, you can fix this by adding margin-bottom:-3.5px;

    header .logo .menu ul a:hover { color: #1d2025; text-decoration: none; font-weight: 700; border-bottom: 3.5px solid #ff7d1a; margin-bottom:-3.5px; }

    and to prevent the links to shift right when hover over due to the font weight change, try to change opacity or color unstead.

    cheers

    Marked as helpful
    0
  • Foued•655
    @Foued80Posted over 2 years ago

    hi, great job, on desktop view you forgot the thumbnails (design/desktop-design-lightbox.jpg).

    1
  • CorizCoder•20
    @CharlesCypherSubmitted over 2 years ago
    1. The sidebar dropdown was difficult for me.
    2. I am not sure of the JavaScript code and some CSS stylings.
    3. I need help, to learn best practices in JavaScript. Please indicate any fault. I will love to see some feedback :)

    Intro section with dropdown navigation

    1
    Foued•655
    @Foued80Posted over 2 years ago

    hi, CorizCoder

    Goodjob, i had the same trouble with the sidebar dropdown menu specialy the padding and margins to hide the submenu;

    check my css only solution for this challenge no single line of javascript was needed, i used input:checkbox with css ~ sibling

    your sidebar is missing a backdrop to the left, and for the best practice i suggest checking bootstrap's code for navbars and dropdown menu for inspiration

    cheers.

    Marked as helpful
    1
  • Foued•655
    @Foued80Posted over 2 years ago

    hello, great work, the sub menus do not collapse after they are displayed

    0
  • Foued•655
    @Foued80Posted over 3 years ago

    hi,

    Here a fix for the the reviews section

    .flex-machine { display: flex; align-items: center; }

    align-items:center will stop the avatar from stretching

    can you tell me how you made the paragraph to shrink and grow with the viewport, i dont see clamp or font-size relative to viewport anywhere in your css :s i may learn something here :O

    0
  • Foued•655
    @Foued80Posted over 3 years ago

    hi,

    1. the desktop view needs a container with a max-width of 1440px

    2. hovering over the nav links shift the content try to force border to 0 on the li's

    3. try the aspect-ration preperty to set the corect width/height of background images

    4. don't use duplicate IDs check your solution report and fix the problems

    Marked as helpful
    0
  • Heritier Akilimali•310
    @heritioSubmitted over 3 years ago

    i keep getting scrollbar and dead space on mobile version even though i have set the width on the body to 100%-95%, sometimes there is no dead space and no scrollbar, and sometimes there is, im not sure why that is happening. I would love some feedback on how to center the body and have no dead space that makes the x scroll bar apear. Thanks for the feedback

    html and css site with flexbox and media queries

    3
    Foued•655
    @Foued80Posted over 3 years ago

    Hi Heritier,

    Be aware that the css is processed from top to bottom, at the begening of the file you put :

    body> margin: 9vh auto; and then @media body> width: 95%;

    for mobile view, you should override the rules if you want something different and remove duplicates @medias if you wan't it to stay as it is .

    cheers

    Marked as helpful
    0
  • Foued•655
    @Foued80Posted over 3 years ago

    Hi Amon, realy cool animations there !

    0
  • Foued•655
    @Foued80Posted over 3 years ago

    Hi Oscar, well done,

    -Not sure if an email like this [email protected] is a valid email ( .c) need at least 2 chars according to Domain Naming Conventions. -The background pattern isn't well scaled nor well positionned

    cheers.

    Marked as helpful
    0