Skip to content
OverviewSolutions
2
Comments
2
Favour Edubio
@Feke21

All comments

  • Favour Edubio•30
    @Feke21Posted over 2 years ago

    Hello Emmanuel, I think the only thing that makes yours different is the colors you used for your background and text and personally i think your code was a bit complex for the work so you could improve on that by using shorter codes for easier understanding.

    At the end of it all, i think your work is quite impressive and i definitely learnt new things from your code. Great job!

    Feke21

    0
  • Gloria Okeke•10
    @GloriaOkekeSubmitted over 2 years ago

    All feedbacks are welcome...

    How is my css styling? I will appreciate if there are better practices

    qr code component

    2
    Favour Edubio•30
    @Feke21Posted over 2 years ago

    Hello Gloria, I have checked through your code and i think some of your issues started with the tags you were using. There shouldn't be a <figure> tag after calling a <div> tag you're supposed to call an <img> tag immediately for the QR code picture to show. There should also not be a <figcaption> tag as well. To be able to comment on your CSS, you will have to make the necessary corrections to your HTML so that it would be easier to understand. All the same, good effort for trying your best. Hope to see an updated version of your work!

    Feke21

    Marked as helpful
    0