qr code component

Community feedback

• 

  Favour Edubio•30

  @Feke21Posted over 2 years ago

  Hello Gloria, I have checked through your code and i think some of your issues started with the tags you were using. There shouldn't be a <figure> tag after calling a <div> tag you're supposed to call an <img> tag immediately for the QR code picture to show. There should also not be a <figcaption> tag as well. To be able to comment on your CSS, you will have to make the necessary corrections to your HTML so that it would be easier to understand. All the same, good effort for trying your best. Hope to see an updated version of your work!

  Feke21

  Marked as helpful

  0

  ---

  

  Gloria Okeke•10

  @GloriaOkekePosted over 2 years ago

  Thank you, Feke

  I will work on that

  0
• 

  Tic_Tac1602•360

  @TicTac1602Posted over 2 years ago

  Hello Gloria, from what I can see the deployment of your solution didn't go well.

  I took time to download your repo and check your work. From what I can see on this one here some an advice:

  -The font used is not the right one, in fact you didn't even import one, it's the default style of your browser. To fix that please refer to your "style-guide. med" file at the bottom you will find the name, font-size, font-weight you need for the project

  -For the mobile version try to work with media queries. It's made it a lot simpler to understand what you did and the liability of the code will be better. (Even thought there is not much to read, but imagine on bigger projects).

  Any ways very nice attempt keep on the good work.

  Tic_Tac

  Marked as helpful

  0

  ---

  

  Gloria Okeke•10

  @GloriaOkekePosted over 2 years ago

  I appreciate your feedback thank you

  0