Skip to content
OverviewSolutions
6
Comments
3
Ashraful Ferdous
@Fariv

All comments

  • Nick•520
    @mrsev17Submitted about 1 year ago

    How i can improve HTML structure? How i can simplify CSS?

    HTML, CSS, Flexbox

    2
    Ashraful Ferdous•180
    @FarivPosted about 1 year ago

    Hi there,

    I just saw your solution and the outcome is really good 👍

    You want to know to simplify your CSS.

    At first glance, I saw the /* Reset CSS */ section. And my instinct is just telling me, why not use

    * {
    margin: 0;
    padding: 0;
    border: 0;
    font-size: 100%;
    font: inherit;
    vertical-align: baseline;
    box-sizing: border-box;
}

    So, I think, first and foremost, you may use above for resetting the CSS for all elements.

    Also, you wish to know about your html structure.

    I think, your html structure is ok, an expert person could give you more insights, I hope.

    Regards, Ashraful

    Marked as helpful
    0
  • ferassmohana•60
    @ferassmohanaSubmitted about 1 year ago

    If anyone has any comment about the code, the structure, specially JS code, don't hesitate telling me!

    Calculate Age

    1
    Ashraful Ferdous•180
    @FarivPosted about 1 year ago

    Hi there,

    I just saw your code and you did great so far! 🙂

    I just want to point out that you could give two more else if checks on month and day after year after line 105

    If you do that, 29/8/2023 will not give negative year.

    Additionally, you may try to get more accurate width and height of the card if you use any image editor tools to get exact pixels of that.

    Regards, Ashraful

    Marked as helpful
    0
  • Ashraful Ferdous•180
    @FarivPosted about 1 year ago

    Hi there,

    I just saw your code and preview.

    You did great so far.

    But There's surely room for improvement.

    I suggest you add the image to the repository, so that image can be seen in Live Site.

    Also you got to give a few margin to both left and right for mobile view.

    Otherwise, all good so far!

    Happy coding 🙂

    Regards, Ashraful

    Marked as helpful
    0