HTML, CSS, Flexbox

Community feedback

• 

  Nguyễn Đức Chính•310

  @chinh1402Posted about 1 year ago

  For your first project, I think this is an okay solution, I might be kind of harsh on this, but:

  1. The spacing between qr code title and the qr image is too close. Try adding some more margin or padding onto it.
  2. The description text is too jammed, which makes it hard to read. You could change the line-height property to fix it
  3. I agreed with Ashraful Ferdous about your reset CSS, and his approach. Alongside of his approach, I'll provide you with the approach I often use on my codes to reset CSS, you can use whichever you want based on your liking

  You can search for normalize cdn on the web, and come to this page, find the one with .min.css then click on "Copy link tag", place it right above your stylesheet.css link, and you're good to go. The codes provided from that link will do the reset CSS job for you.

  Everyone starts somewhere, hope to see more of your solutions in the future

  Marked as helpful

  0
• 

  Ashraful Ferdous•180

  @FarivPosted about 1 year ago

  Hi there,

  I just saw your solution and the outcome is really good 👍

  You want to know to simplify your CSS.

  At first glance, I saw the /* Reset CSS */ section. And my instinct is just telling me, why not use

  * {
      margin: 0;
      padding: 0;
      border: 0;
      font-size: 100%;
      font: inherit;
      vertical-align: baseline;
      box-sizing: border-box;
  }
  

  So, I think, first and foremost, you may use above for resetting the CSS for all elements.

  Also, you wish to know about your html structure.

  I think, your html structure is ok, an expert person could give you more insights, I hope.

  Regards, Ashraful

  Marked as helpful

  0