Skip to content
OverviewSolutions
2
Comments
2
Facundo Masino
@FacuMasino

All comments

  • ConnorO•80
    @conogiSubmitted over 2 years ago

    Much better this time around! Feedback is appreciated!

    Order Summary

    1
    Facundo Masino•20
    @FacuMasinoPosted over 2 years ago

    Hi Connor, Great Work! This is my feedback: You need to fix the background, try to add the property "background-repeat: no-repeat" on body { } CSS, this is the reason because you get a wrong background and it isn't like the original design. Also the <a> link color of "change" isn't correct because is the default link color.

    Hope it helps you :)

    0
  • Lasha•50
    @lashaarveladzeSubmitted over 2 years ago

    Hey Guys 🤩

    I made this project (I am proud of myself really 🥰).

    I have one "problem" about that like if you see the project preview there is a text layout different and I don't know how to fix it🤦‍♂️

    P.S on small screens it is "fixed"

    all help is appreciated 🥰🤩

    qr-code-component-main

    1
    Facundo Masino•20
    @FacuMasinoPosted over 2 years ago

    Hi ! Your solution looks great :) Only two things:

    1. The problem with text layout is becasue you need to add more padding to "cont" div, in the design the padding for text is diferent from the QR.
    2. The accessibility issue in the report is because you have an <h2> tag instead of <h1>, this isn't a good practice for semantic HTML.

    Nice job!

    1