qr-code-component-main

Community feedback

• 

  Facundo Masino•20

  @FacuMasinoPosted over 2 years ago

  Hi ! Your solution looks great :) Only two things:

  1. The problem with text layout is becasue you need to add more padding to "cont" div, in the design the padding for text is diferent from the QR.
  2. The accessibility issue in the report is because you have an <h2> tag instead of <h1>, this isn't a good practice for semantic HTML.

  Nice job!

  1

  ---

  

  Lasha•50

  @lashaarveladzePosted over 2 years ago

  @FacuMasino Thank you for your support ❤ I fixed everything, this was helpful, but I have one more question about that, when you mentioned that I have to change the h2 tag to h1, then the text becomes really big, and what the point of that if I have to style font-size of it ?

  P.S after the padding its approximately 95% match (it's hard to make 100% without Figma😅)

  1

  

  Facundo Masino•20

  @FacuMasinoPosted over 2 years ago

  @lashaarveladze Great! The size of h1 h2 isn’t important, you can style it with css, but the point is the semantic meaning for the search engines of h1 tag because they will be using it to know what is your page main topic. You can learn more about here https://www.w3schools.com/html/html_headings.asp

  0