Skip to content
OverviewSolutions
10
Comments
5
Etno Polino
@EtnoPolino

All comments

  • Issa Habhab•100
    @Issahab2Submitted over 2 years ago

    I know that it needs furthermore improvements but proud regardless! First time doing a section this big with HTML, CSS and JavaScript.

    Issa's intro-section

    1
    Etno Polino•180
    @EtnoPolinoPosted over 2 years ago

    On the desktop view, You have an issue with the hover of your navigation bar. We should be able to hover "feature", "compagny" AND be able to access the sub-menu.. which is quite hard to do. This is due because you have a blank space between "feature", "compagny" and their respective sub-menu dropdown, so when when your mouse isnt hovering it removes the sub-menu and we cant access it.

    I guess you should either increase the padding of your "feature", "compagny" to make it collide with your sub-menu padding/position, or you change your sub-menu dropdown position.

    Marked as helpful
    0
  • Troy•170
    @troy03Submitted over 2 years ago

    How can I simultaneously hover the social links a border and a logo and there is a problem to my code what advice you will give?

    Flexbox and social link hover

    3
    Etno Polino•180
    @EtnoPolinoPosted over 2 years ago

    How can I simultaneously hover the social links a border and a logo and there is a problem to my code what advice you will give?

    This is happening because you used border-radius = 50% on <li> instead of the <i> element. Actually on your code, you used CSS on <li> instead of <i> this is what you have :

    li {
      border: solid 2px #fff;
      background: none;
      padding: 0.2em;
      padding: 0.4em;
      width: 40px;
 }
 
   ul li:hover, i:hover{
      border-color: hsl(300, 69%, 71%);
      color:  hsl(300, 69%, 71%);
}

    remove that and use something like :

    i {
      border: solid 2px #fff;
      background: none;
      padding: 0.2em;
      padding: 0.4em;
      width: 40px;
 }
  
     i:hover{
        border-color: hsl(300, 69%, 71%);
        color:  hsl(300, 69%, 71%);
     }

    it'll work.

    Good Luck.

    Marked as helpful
    1
  • Etno Polino•180
    @EtnoPolinoPosted over 2 years ago

    the html's issues dont make a single sense to me...

    0
  • Etno Polino•180
    @EtnoPolinoPosted over 2 years ago

    oh i also forgot, if you happen to change and use the <ul> <li> and <a> you would also need to prevent the event default for the Features, Compagny and their arrows since you're going to hover them anyways and wouldnt want them to send an user of your website to another one if they happen to click while hovering.

    1
  • Etno Polino•180
    @EtnoPolinoPosted over 2 years ago

    Hello, Your desktop result visually is good to me. I have 0 understanding at scss, everytime i look at people code with css, everything is confusing.

    Now, here is some common thing you need to change..

    NAVIGATION BAR

    on you Navigation bar (nav), instead of your div class dropdown, you would rather use a list and put the element in a <ul>, then <li> element, then <a> element. it's better to do that than using a cursor pointer at your div. All the features (Features, Compagny, Careers, About, Login, Register) are supposed to be link to webpage, that's why you should use <a> elements So it would be better to have something like :

           <ul>
           <li><a href="any webpage link you want">Features</a></li>
            <li><a href="any webpage link you want">Features</a></li>
             <li><a href="any webpage link you want">Features</a></li>
              etc..
         <ul>
    <nav> ```

then you play with the display : flex, work with the justify-content, marging etc.. to have the desired result.
    Marked as helpful
    1