JavaScript SCSS Hamburger with animation

Community feedback

• 

  Etno Polino•180

  @EtnoPolinoPosted over 2 years ago

  Hello, Your desktop result visually is good to me. I have 0 understanding at scss, everytime i look at people code with css, everything is confusing.

  Now, here is some common thing you need to change..

  NAVIGATION BAR

  on you Navigation bar (nav), instead of your div class dropdown, you would rather use a list and put the element in a <ul>, then <li> element, then <a> element. it's better to do that than using a cursor pointer at your div. All the features (Features, Compagny, Careers, About, Login, Register) are supposed to be link to webpage, that's why you should use <a> elements So it would be better to have something like :

         <ul>
             <li><a href="any webpage link you want">Features</a></li>
              <li><a href="any webpage link you want">Features</a></li>
               <li><a href="any webpage link you want">Features</a></li>
                etc..
           <ul>
      <nav> ```
  
  then you play with the display : flex, work with the justify-content, marging etc.. to have the desired result.
  

  Marked as helpful

  1
• 

  Etno Polino•180

  @EtnoPolinoPosted over 2 years ago

  oh i also forgot, if you happen to change and use the <ul> <li> and <a> you would also need to prevent the event default for the Features, Compagny and their arrows since you're going to hover them anyways and wouldnt want them to send an user of your website to another one if they happen to click while hovering.

  1