I'm still very new to html and css, only 1 month in, so I'll appreciate any advice on how to improve my skills! :)
idukpaye alex
@Esesosa-maxAll comments
- @dpiskovSubmitted 9 months ago@Esesosa-maxPosted 9 months ago
Great Attempt, Approach Could be better (70 /100)
- Great Design, pretty much pixel-perfect
- Do not use a
<main>
tag to make a card because it is not semantically correct - Read HTML Semantics, it is okay to use multiple divs
- So next time, use a
<div>
and give a class of container or use another tag but do not a<main>
- Try using CSS variables it is nice!
- Do you know Flexbox? or CSS Grid?
- if not learn it, it will make centering much much easier
- Not Quite impressed, with the way you centered the
<main>
- Not Quite Responsive but the way you did it was smart
- Good Usage of Relative units like em or rem
Marked as helpful1 - @viniciussisSubmitted 9 months ago
I had difficulties implementing the main logic of the calculator; it's not 100% accurate, especially regarding the days. I couldn't manage to implement the animation bonus; I don't have experience with animations yet, and I don't want to spend too much time on this project as I intend to start working on others.
@Esesosa-maxPosted 9 months agoGood Attempt( 65/100), but not quite right.
- Regarding the CSS, Great Job there.
- Not quite impressed with the validation there is no custom validation
- Do not use HTML built-in validators use your own
- Yeah, the custom validation is the only thing preventing you from getting a 90/100
Marked as helpful0 - @NorwyxSubmitted 9 months ago
All feedback appreciated
@Esesosa-maxPosted 9 months ago- Flawless, Could not find any flaws (100/100)
- Good HTML Structure
- Nicely Responsive
1 - @francis835Submitted 9 months ago
The challenge helped me more with my HTML and CSS skills as a Front-end developer and again I'm also a new member here and it's my second time completing the challenge. I'm hoping to do more of the challenges.
@Esesosa-maxPosted 9 months ago- Not quite flawless but pretty great 90/100.
- The heading should not be bold.
- The HTML Structure is ok.
0 - @hiofadlikaakbarSubmitted 9 months ago
uh... ignore the ugly preview thumbnail
@Esesosa-maxPosted 9 months agoCompletely nothing like the original design but it is pretty cool. I just hoped you put a better anime. It is even cooler than the original design but i wouldn't employ you with that anime.
0 - @NasifuadSubmitted 9 months ago
I have designed in Edge which got everything perfect but in the hosting site the design seems not in order donno
@Esesosa-maxPosted 9 months agoGood Attempt, but not quite pixel-perfect because you didn't quite it right (45/100)
- Firstly, the paragraph text in the cards is just too much
- Heading text is still too much
- Padding in the card is just too much (reduce it from 30px to like 15px)
- Wrong font usage, to get the design right it is very crucial
- Please use
<p>
instead of a<h3>
in the header - Why is the paragraph text 20px? use the right font and reduce it to 17px
- Why is it NOT responsive? this made you lose points
- Try to collapse everything by giving the
.card-holder
in a media queryflex-direction:column
- Props to getting the card layout with
.middle-cards
- Try using CSS variables it is nice!
- The reason the font is not working is because you did not import the URL from google fonts, google how to do this.
Marked as helpful0 - @gio-cmdSubmitted 9 months ago
:))
@Esesosa-maxPosted 9 months agoNot impressed with the HTML structure, why use a
<main>
tag like that? what you should do is put a<div>
with a class ofcard-container
, and then apply those styles to themain
. Amain
tag is used to contain a lot of elements and using it for one component like a card is not ideal, say you want to have multiple cards, by your code you would have to duplicate the main tag right? but if put inside adiv
class ofcard-container
to contain it duplicating is a piece of cake.Good Solution 80/100 (do not coky it is an easy challenge)
0 - @dan9hSubmitted 9 months ago
All suggestions and feedbacks are welcome.
Keep coding y'all!
@Esesosa-maxPosted 9 months agoGreat solution, love the animation, pretty much pixel-perfect but the validation isn't quite there yet because I put it on a date that didn't exist and it gave me -1 year and something. You made it responsive, pretty impressive by the way.
Marked as helpful0 - @lumiukoSubmitted 10 months ago
Any feedback will be appreciated ✌
@Esesosa-maxPosted 10 months agoOkay, Completely Flawless, Perfectly Responsive. You are a Boss but a Boss like you should add animations it is required so 100/100 but -10 for not adding level animation so 90/100.
1 - @JTieppoSubmitted 10 months ago
Have you ever thought about how many days and months you have been alive? The age calculator was created to answer any questions and clear up any doubts about that. If it's your birthday, I have a surprise for you. Have fun!
@Esesosa-maxPosted 10 months agoOkay, Nice Animation for the Birthday. You Get Extra Points for that (65/100) but you still need some work
0 - @JTieppoSubmitted 10 months ago
Have you ever thought about how many days and months you have been alive? The age calculator was created to answer any questions and clear up any doubts about that. If it's your birthday, I have a surprise for you. Have fun!
@Esesosa-maxPosted 10 months agoFirstly, Love the animation but overall not impressed at all (a 55/100). See, there is no validation, and inputs seem completely regular, but I will say: that it is pretty responsive great job there. The arrow make me angry, not impressed at all. What you should put the arrow inside a button, give that button a background color and scale down the image or find a way to scale it down using your HTML structure. I do have to ask, why the dark theme? why the different themes on desktop and mobile? hahaha nice!
0 - @abelkm99Submitted over 1 year ago
All feedbacks are welcome.
@Esesosa-maxPosted over 1 year ago- ✅ Responsive 4/5
- 🆗Good HTML Structure 3/5
- ✅Correct font and font-sizing 5/5
- ✅ More Accurate than the design 5/5
- ❌ Failed to give the button
cursor:pointer
on hover (yes I know it is a small detail) - ❌ Wasn't impressed by the way you centered the whole thing
1