Skip to content
OverviewSolutions
3
Comments
5
EmmanuelUrias
@EmmanuelUrias

All comments

  • Coty B•405
    @cotybroSubmitted over 1 year ago

    Oh boy what a challenge. I had a lot of fun with this one like always. still learning React JS and this helped a lot with state and passing props! Any and all feedback welcome!

    Multi-Step Form Made With ReactJS

    2
    EmmanuelUrias•130
    @EmmanuelUriasPosted over 1 year ago

    Great job, you did a much better job than I did with it.

    1
  • EmmanuelUrias•130
    @EmmanuelUriasPosted over 1 year ago

    Great job, some UI advice would be to make the large text a bit smaller to fit better and have better proportions within the card. After looking at your codebase some things I'd point out is that the h2 tag you use for the large text should an h1 then you would make it smaller with css. When you start building larger projects your class name/styling system would get verbose, I would recommend learning how to structure the elements and giving them specific classes like <main class='card-container'> then giving it all it's style properties in the css with the selector - .card-container{
    flex-direction: column; justify-content: center; align-items: center; } Other than that great job!!

    Marked as helpful
    1
  • Codenaud•130
    @codenaudSubmitted over 1 year ago

    🚀 Hello from the outer space...

    This is my solution for: "QR code component" challenge.

    🧑‍🚀 Bonus [code]:

    I've added a small zoom animation with "css" on the QR image.

    I'll be happy to hear any feedback and advice!

    Thank's

    QR code component

    2
    EmmanuelUrias•130
    @EmmanuelUriasPosted over 1 year ago

    Looks great the only I would add is to make the font in the subtext larger for better accessibility, that change would make it near perfect.

    Marked as helpful
    0
  • EmmanuelUrias•130
    @EmmanuelUriasPosted over 1 year ago

    Great job looks great the only thing I have to add is that adding padding to the bottom of it would make it perfect.

    0
  • KabongeHajarah•40
    @KabongeHajarahSubmitted over 1 year ago

    1.Are there any best practices in terms of CSS styling or HTML structure that I could improve upon? 2.Is the image optimization done effectively for fast loading times and optimal performance? 3.Are there any areas of my code that could be refactored or optimized for better efficiency?

    Do you have any suggestions or feedback on the choice of fonts, colors, and overall design aesthetics of the website? Are there any other best practices or recommendations that I should be aware of to improve the quality and performance of my front-end project?

    I used html structure and css , and use of divs and classes selectors

    3
    EmmanuelUrias•130
    @EmmanuelUriasPosted over 1 year ago

    It looks great, but some things I'd like to point out is that putting some more padding on the bottom would be more aesthetically pleasing, and making the card wider would have made the text fit better within it. Looked at your code base and I would recommend having a consistent format when it comes to tabbing and line spaces to make it more readable and overall look cleaner. Another important thing is a really consistent naming style, you went from camel case with mainDiv to kebab case for code-div. Other than that great job!

    Marked as helpful
    0