QR code component

Community feedback

• 

  EmmanuelUrias•130

  @EmmanuelUriasPosted over 1 year ago

  Looks great the only I would add is to make the font in the subtext larger for better accessibility, that change would make it near perfect.

  Marked as helpful

  0

  ---

  

  Codenaud•130

  @codenaudPosted over 1 year ago

  Hello, @EmmanuelUrias, thank you very much for your appreciation. You are absolutely right, the text looked too small so I changed it. Thank you very much for advice.

  0
• 

  Fer•3,970

  @fernandolapazPosted over 1 year ago

  Hi 👋, I leave this here in case you want to take a look:

  HTML 🧱, ACCESSIBILITY ⚖:

  🔹Semantic elements: Every page should have an <h1>, to improve the user experience and because it is one of the most important elements on a web page when it comes to SEO.

  🔹This is a meaningful image and therefore the alt text should give a good description in case the user cannot see it for some reason. Something like 'Qr code to the Frontend Mentor site'.

  CSS 🎨:

  🔹It is better to use min-height: 100vh; for the body, as using the height might cause the page to be cut off in viewports with small height (such as mobile landscape orientation).

  Please let me know if you disagree with something or if you would like more information on any of these topics.

  If you have any questions I’m here to answer so don't hesitate 🙂

  Regards,

  Marked as helpful

  0

  ---

  

  Codenaud•130

  @codenaudPosted over 1 year ago

  Hello @fernandolapazs, thank you very much for your comments.

  I added an h1 header as you recommended, along with some more specific text in the image alt.

  Your comment about changing the body height from (%) to (vh) a much more appropriate measurement also helped me a lot.

  Thank you!! 🤘

  0