@YuliaLantzberg
Submitted
What are you most proud of, and what would you do differently next time?
I started to feel more fluent about grid, flex and CSS in general.
@Efelipa
@YuliaLantzberg
Submitted
What are you most proud of, and what would you do differently next time?
I started to feel more fluent about grid, flex and CSS in general.
@Efelipa
Posted
Great solution Yulia, Both the design and the code are clean, superb. An efficient way to use grid could be to create a structure where only the cards are placed.
<section class="grid | other classes">
<article>
... Card header and stuff
</article class="card">
</section>
@Kostexx
Submitted
What specific areas of your project would you like help with?
Any constructive criticism is welcome.
@Efelipa
Posted
Both the design and the code are clean, superb. An efficient way to use grid could be to create a structure where only the cards are placed.
<section class="grid | other classes">
<article>
...Header and stuff
</article class="card">
</section>
Marked as helpful
@Maxked-Code
Submitted
@Efelipa
Posted
Nice classes and style. Avoid using unnecessary div's and add a border to the card. Other than that, great job!!
@YuliaLantzberg
Submitted
@Efelipa
Posted
It's exactly, well done. In the discount price, just have to center the price, if you're using flex just apply align-self: center to discount price to solve it. Semantic are correct.
Marked as helpful
@magedashraf73
Submitted
@Efelipa
Posted
Desktop display is good, it is very similar to the sample. You have to implement a responsive solution to the mobile view. Avoid use just div's. Semantic HTML will help you to solve this and bring you help when you need organize your page.
Marked as helpful
@MohamedAbdelBAQIMo
Submitted
@Efelipa
Posted
Nice design, image rounded it's a different edge and that's ok. The attribute could be as a footer, you can apply styles on it as well
Marked as helpful
@sikulamartin
Submitted
@Efelipa
Posted
Different labels are key, they're will increase your performance and help you with SEO
@Dhruvm2004
Submitted
What are you most proud of, and what would you do differently next time?
this is a short achievement and i would like to make more user specific
What challenges did you encounter, and how did you overcome them?
making suitable for all devices to view but i was able to manage
What specific areas of your project would you like help with?
design part
@Efelipa
Posted
This is a first step in this path. Make sure you use semantic HTML, labels like articles could be useful. In CSS, media queries it's amazing to create responsive designs.