Skip to content
OverviewSolutions
7
Comments
8
Erick Felipa Pineda
@Efelipa

All comments

  • Erick Felipa Pineda•160
    @EfelipaPosted 3 months ago

    Great solution Yulia, Both the design and the code are clean, superb. An efficient way to use grid could be to create a structure where only the cards are placed.

    <section class="grid | other classes">
    <article>
        ... Card header and stuff
    </article class="card">
</section>
    0
  • Erick Felipa Pineda•160
    @EfelipaPosted 3 months ago

    Both the design and the code are clean, superb. An efficient way to use grid could be to create a structure where only the cards are placed.

    <section class="grid | other classes">
    <article>
        ...Header and stuff
    </article class="card">
</section>
    Marked as helpful
    1
  • Erick Felipa Pineda•160
    @EfelipaPosted 3 months ago

    Nice classes and style. Avoid using unnecessary div's and add a border to the card. Other than that, great job!!

    1
  • Erick Felipa Pineda•160
    @EfelipaPosted 3 months ago

    It's exactly, well done. In the discount price, just have to center the price, if you're using flex just apply align-self: center to discount price to solve it. Semantic are correct.

    Marked as helpful
    1
  • Erick Felipa Pineda•160
    @EfelipaPosted 3 months ago

    Desktop display is good, it is very similar to the sample. You have to implement a responsive solution to the mobile view. Avoid use just div's. Semantic HTML will help you to solve this and bring you help when you need organize your page.

    Marked as helpful
    1
  • Erick Felipa Pineda•160
    @EfelipaPosted 3 months ago

    Nice design, image rounded it's a different edge and that's ok. The attribute could be as a footer, you can apply styles on it as well

    Marked as helpful
    1
  • Erick Felipa Pineda•160
    @EfelipaPosted 3 months ago

    Different labels are key, they're will increase your performance and help you with SEO

    0
  • Dhruvm2004•20
    @Dhruvm2004Submitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    this is a short achievement and i would like to make more user specific

    What challenges did you encounter, and how did you overcome them?

    making suitable for all devices to view but i was able to manage

    What specific areas of your project would you like help with?

    design part

    Responsive CSS and HTMl qr

    2
    Erick Felipa Pineda•160
    @EfelipaPosted 3 months ago

    This is a first step in this path. Make sure you use semantic HTML, labels like articles could be useful. In CSS, media queries it's amazing to create responsive designs.

    0