@jolman009Submitted 3 months ago
Eric Aguayo
@EAguayodevAll comments
- @EAguayodevPosted 2 months ago
Great job on the challenge. Here is some feedback: -HTML,CSS, and Javascript structure was easy to follow and understand when it comes to the solution. -Layout looks good on most screen sizes.
- Close to the design, suggest making the height of the overall card inside the container a bit bigger to match the design in regards to the width and height.
0 - @marynaKolikovaSubmitted 3 months ago@EAguayodevPosted 3 months ago
Code is well structured and easy to follow when understanding the process of the final outcome.
Great job putting the font sizes in rem units for accessibility.
0 - @MateuszZalewSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
Pretty satisfied with the overall result
What challenges did you encounter, and how did you overcome them?Changing the position of the "See all" button was challenging, had to refactor the code, but managed to overcome the problem with the
What specific areas of your project would you like help with?grid-template-areaspropertyAny feedback would be appreciated, thanks
@EAguayodevPosted 3 months agoGreat job on completing the challenge. Your code is well structured and was readily readable from the HTML, CSS, and JavaScript code. I also learned and saw how you could put the button at the bottom on mobile using the grid-template-area property.
Overall, well with tiny improvement needs ensuring all headings and p's have rem units for accesbility.
1 - @Ayomide-PhilipSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
Think Outside the box
What challenges did you encounter, and how did you overcome them?By thinking more
What specific areas of your project would you like help with?CSS animations
@EAguayodevPosted 3 months agoGreat job completing the challenge. The only recommended change is to change the width percentage on the desktop to 26% form 20% to match the expected design outcome.
0 - @clyoSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
n/a
What challenges did you encounter, and how did you overcome them?n/a
What specific areas of your project would you like help with?n/a
- @Chirtoaca94Submitted 4 months agoWhat are you most proud of, and what would you do differently next time?
Working with the DOM to manipulate the success message and newsletter page.
@EAguayodevPosted 3 months agoGood job on the challenge. Just a few light changes can be made to the challenge by changing the background color of the body to hsl(234, 29%, 20%);
- Background color is added to the newsletter container to #fff.
0 - @G-GakiiSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud of my ability to effectively utilize the Toggle feature in JavaScript
What challenges did you encounter, and how did you overcome them?Using Toogle, I first viewed a video before putting it into practice.
What specific areas of your project would you like help with?I would welcome any comments on how to do better.
@EAguayodevPosted 3 months agoGreat work on writing clean Javascript. One thing I did that you can improve on is adding a smooth transition when the user toggles the questions.
1 - @HekimianzSubmitted 3 months ago@EAguayodevPosted 3 months ago
Your code is well structured in the HTML, CSS, and Javascript portions of the project. I found it easy to follow and read so that I could understand how everything functions.
Improvements: add more concise and clear alt texts on the images.
Marked as helpful1 - @curiousdilipSubmitted 4 months ago@EAguayodevPosted 3 months ago
The design and code are clean and look great across multiple devices. In the future, creating an external stylesheet for the CSS can make it easier for others to read your code.
0 - @medaichSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud that I can use Mobile First approach to implement the needed.
What challenges did you encounter, and how did you overcome them?It was quite straightforward.
What specific areas of your project would you like help with?I need to know more about box-shadow. I tried to use it to make the shadow on the card sides look like the design, but it was hard. Especially the blur property.
@EAguayodevPosted 3 months agoThe styles and responsiveness of the challenge come out well. For the HTML semantics, putting the h1, p, svg's into one div inside each section tag will remove the horizontal scroll on mobile devices.
0 - @eominiSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
Otimizaria o codigo, muito a melhorar
What challenges did you encounter, and how did you overcome them?em tags como a da tabela na parte de nutritction
What specific areas of your project would you like help with?Em tags como a da tabela e em responsividade
@EAguayodevPosted 3 months agoHere are some improvements that can be made to this challenge:
- Add media queries to make the challenge responsive using @media(max-width: 48rem) since your code was done with the desktop's first workflow.
- use a reset inserting the *{ box-sizing: border-box; padding: 0; margin: 0;}
Great work on the HTML semantics.
0 - @celistialcurseSubmitted 3 months ago@EAguayodevPosted 3 months ago
Performed exceptionally in developing well-structured HTML and CSS, achieving a close resemblance to the design.
0
