All comments

• 

  P

  Kamran Kiani•2,760

  @kaamiikSubmitted 6 months ago

  What are you most proud of, and what would you do differently next time?

  I'm most proud of how I integrated accessibility into the hamburger menu and achieved a responsive design across various components. Using Sass and CUBE CSS for styling allowed me to create a modular and maintainable codebase, especially as I built responsive grids in both the about and products sections. Next time, I’d like to experiment with a CSS framework like Tailwind to streamline some of the utility classes and explore more efficient ways to achieve responsive layouts.

  What challenges did you encounter, and how did you overcome them?

  One of the primary challenges was designing an accessible hamburger menu that worked smoothly across devices. I focused on making it accessible by implementing keyboard navigation and ensuring screen readers could interact with it easily. The responsive grid layout for the products section was also challenging, particularly in making it adapt well between mobile and desktop. For this, I utilized CSS Grid and media queries in combination to ensure it displayed optimally on different screen sizes.

  What specific areas of your project would you like help with?

  I would like feedback on the HTML structure, especially regarding semantic use, and on the accessibility features I implemented. Additionally, any insights into optimizing CSS for responsive layouts or suggestions on how to further refine my Sass and CUBE CSS code for maintainability would be valuable.

  

  Loopstudios Landing Page using Astro, Sass and CUBE CSS

  #accessibility#astro#cube-css#sass/scss

  1

  10
  

  Elizabeth Shackelford•50

  @E-C-ShackelfordPosted 6 months ago

  I want to acknowledge that I don't have experience with Astro, but as I explored your file structure and code, I found your organization to be clear. Separating concerns into folders like pages, layouts, components, styles, vendors, and subfolders and files improves your project's readability and maintainability.

  You have prioritized accessibility and user experience with keyboard-triggered focus states and ARIA attributes, and your consistent use of clear, descriptive variable and class names quickly communicates each class and variable's purpose.

  Your Product section's 'See All' button seems too small, which might affect some users' visibility and usability on mobile devices. I would experiment with different padding and font sizes–increasing these sizes could help mobile users tap the 'See All' button more easily.

  Perhaps add some comments to your code to ensure greater clarity, both for future developers and for yourself.

  Your file structure is solid, and your code is maintainable, accessible, and demonstrates strong attention to detail. You've done some great work in your solution to this challenge. I wish you the best of luck as you continue your coding journey!

  Marked as helpful

  0
• 

  Emerson Lima•200

  @poissonfouSubmitted 7 months ago

  What are you most proud of, and what would you do differently next time?

  .

  What challenges did you encounter, and how did you overcome them?

  .

  What specific areas of your project would you like help with?

  .

  

  grid layouts and media queries

  #bem#accessibility

  1

  20
  

  Elizabeth Shackelford•50

  @E-C-ShackelfordPosted 7 months ago

  Hi! Great work on developing your card component! I have a few suggestions that could enhance both accessibility and clarity. First, consider using more semantic HTML elements, such as <article> instead of <div> where it makes sense. This can improve the structure of your code and make it easier for assistive technologies to understand.

  I noticed you're using relative units for padding and margins, which is great, but I recommend also using relative units for font sizes rather than pixels. This will make your card component more adaptable and accessible for users who adjust their text size.

  Take another look at your CSS for classes with many common properties. Creating a shared class for these styles can help keep your stylesheet cleaner and easier to manage.

  You've made a great start with this card component. Keep up the great work!

  0